Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Levant dispatch command to dispatch against Nomad jobs. #128

Merged
merged 1 commit into from
Mar 26, 2018

Conversation

jrasell
Copy link
Member

@jrasell jrasell commented Mar 25, 2018

Levant now has the functionality to dispatch against Nomad jobs
using the dispatch command. Jobs that are dispatched go through
the job status checker and so dispatched jobs can be confirm to
reach the running state.

Closes #113

Levant now has the functionality to dispatch against Nomad jobs
using the dispatch command. Jobs that are dispatched go through
the job status checker and so dispatched jobs can be confirm to
reach the running state.

Closes #113
@jrasell
Copy link
Member Author

jrasell commented Mar 25, 2018

@sevagh I had some time to complete my started work today so raised this PR and would love any feedback you have.

@sevagh
Copy link

sevagh commented Mar 26, 2018

I'll compare this directly to my code later today, but it looks good. Mine is definitely more hacky (e.g. not supporting payloads, and passing -meta as a single comma-separated list instead of multiple flags).

I suspect the dispatch behavior is the same as nomad job dispatch? Return a successful allocation.

I'll compile your branch and run it with my arguments today as a sanity check.

@jrasell
Copy link
Member Author

jrasell commented Mar 26, 2018

The run behaviour is identical; but it will go through the additional checking that Levant provides and so will ensure that the dispatched job reaches the running state as well as all the allocations that are part of it.

@stevenscg
Copy link

I use the heck out of dispatch jobs. Nice work!

@sevagh
Copy link

sevagh commented Mar 26, 2018

Works nice for me.

I still rely on code from here (-monitor and -timeout) to poll Nomad and check for the end result of the dispatched job.

@sevagh
Copy link

sevagh commented Mar 26, 2018

Once that other PR is merged independently, extending both deploy and dispatch to support the blocking behavior should be entirely possible. I didn't mean to imply that this PR is unusable without the other one.

@jrasell jrasell merged commit 40ac877 into master Mar 26, 2018
@jrasell jrasell deleted the f_gh_113 branch March 26, 2018 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants