Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating nomad version to 0.8.0 #137

Merged
merged 2 commits into from
Apr 18, 2018
Merged

Updating nomad version to 0.8.0 #137

merged 2 commits into from
Apr 18, 2018

Conversation

maksym-iv
Copy link
Contributor

Due to recent Nomad release would be nice to update dep

@jrasell
Copy link
Member

jrasell commented Apr 17, 2018

hi @xmackex thanks for the PR. Is there a requirement to update the Nomad dependency?

@maksym-iv
Copy link
Contributor Author

Hi @jrasell fortunately now (as far as I fount)

I just updated Nomad, ran Levant and got some errors, only after I've updated dep and tested with new binary I have discovered that when I updated Nomad I have not restarted it. So both old and new version of lib working.

Potentially there can be issues with job validation due to Hashicorp have introduced one new stanza and updated several of old (check_restart)

@jrasell
Copy link
Member

jrasell commented Apr 17, 2018

OK that makes sense.

Alongside this, could you please raise an issue against the project detailing the issue you're facing, it will help me make sure the 0.8.0 release has not caused any other issues.

@maksym-iv
Copy link
Contributor Author

Due to my mistake I identified issue in wrong way. So now there is no issue. Just cause I've already build it locally with new version I've decided to make a PR.

Sorry if this is wrong way, unfortunately don't have much experience with OpenSource development.

@jrasell
Copy link
Member

jrasell commented Apr 18, 2018

OK. I will hold this until 0.1.1 and do some testing as I want to get 0.1.0 out today or tomorrow.

@jrasell
Copy link
Member

jrasell commented Apr 18, 2018

Update - I will push this out now as part of 0.1.0

@jrasell jrasell merged commit cd72171 into hashicorp:master Apr 18, 2018
@maksym-iv
Copy link
Contributor Author

@jrasell Is there any slack channel etc for this project? Probably I could help with testing/development, but not sure how "often" I could do it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants