-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/include vault token in deployment #258
Feature/include vault token in deployment #258
Conversation
@ebarriosjr thanks a lot for this. Before I merge this in I am curious what is secure introduction method will be when supplying a token via the CLI? |
@jrasell I believe supplying the token via the cli is not secure. Depends mostly on how you use Levant. I would say that the recommended way will be to use the env variable but it is nice to have the possibility of sending the token via the cli for testing imho. |
This patch always uses the env var VAULT_TOKEN if it exists, as long as no command line switch is passed in? Just thinking if that would get troublesome in CI environments that might have a more permissive token set in the environment by default. |
Hi @redfive |
@redfive raises a nice point where unintentional side effects could arise if the user doesn't understand the internals of the CLI flag. Taking this into consideration @ebarriosjr, how would you feel about having this flag only as an explicit CLI passed variable, and adding another which would read the env var (I would guess they would be exclusive and you can only provide one of the two)? |
@jrasell I worked on it as promised and now we have two flags: |
thanks a lot @ebarriosjr |
No description provided.