Update Levant deployment to inspect the evaluation results. #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nomad can return an evaluation which has incurred errors due to issues such as resource starvation. Previously Levant only checked whether an actual API error was returned from the evaluation call which meant errors during this phase were not caught. This change implaments an evaluation inspector which iterates through any errors during an evaluation to provide this feedback to the user. Closes #39
pmcatominey
reviewed
Nov 23, 2017
| *evalID, evalInfo.Status) | ||
|
|
||
| default: | ||
| time.Sleep(1 * time.Second) |
There was a problem hiding this comment.
With the eval being fetched outside the loop it seems this is the cause for Levant hanging eternally now?
There was a problem hiding this comment.
Yeah, that is dumb. Will fix.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nomad can return an evaluation which has incurred errors due to
issues such as resource starvation. Previously Levant only
checked whether an actual API error was returned from the
evaluation call which meant errors during this phase were not
caught.
This change implaments an evaluation inspector which iterates
through any errors during an evaluation to provide this feedback
to the user.
Closes #39