Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI tests in modules #436

Closed
jraska opened this issue Mar 20, 2021 · 3 comments · Fixed by #504
Closed

UI tests in modules #436

jraska opened this issue Mar 20, 2021 · 3 comments · Fixed by #504

Comments

@jraska
Copy link
Owner

jraska commented Mar 20, 2021

  • Shared folder to all be executed with Firebase
  • Source dir shoudl work
  • Should be possible to execute in isolation
@jraska jraska modified the milestone: 0.25.0 Mar 27, 2021
@jraska
Copy link
Owner Author

jraska commented Mar 28, 2021

Similar problems like with the partial app - it is necessary t oreduce the amount of boilerplate to setup the partial app

Some topics:

  • Themes, Permissions - manifest stuff
  • Threading - different than unit tests
  • Syncing within Android Studio is challenging
  • Test has to use public stuff - at the moment something is not public - it silently does not run - possibly restricting internal stuff
  • Without AssertJ, the test runs 25-60ms, with AssertJ it is +100ms - 130-170ms - probably because of large class loading and bigger test APK

@jraska
Copy link
Owner Author

jraska commented Apr 13, 2021

I think the conclusion now is it is not worth to have Activiity/Fragment tests within modules tests, but trying to move as much code out of Activities, which would mean AActivity to have only responsibility of

  • Delegting to some Binder
  • Holding the ViewModel
  • Observing ViewState and calling it to Binder

Such Binder could be well tested in isolation

@jraska
Copy link
Owner Author

jraska commented May 1, 2021

Resolved by #504

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants
@jraska and others