Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cumulative flag should be tested against False #3

Closed
jrbenito opened this issue Oct 24, 2018 · 0 comments
Closed

Cumulative flag should be tested against False #3

jrbenito opened this issue Oct 24, 2018 · 0 comments

Comments

@jrbenito
Copy link
Owner

jrbenito commented Oct 24, 2018

power_imp=None, temp=None, vdc=None, cumulative=False, vac=None,

if cumulative is not None:

Cumulative flag is being defined as False by default and tested against None, this causes C1=1 for every single request.

Better to test it against True instead of redefine it as None because this way any non default value besides True will end up default c1 at pvoutput (default as today is c1=0)

jrbenito added a commit that referenced this issue Oct 24, 2018
-> Cumulative flag must be set to True to make `c1=1`, any other value
will result in `c1=0`.

closes #3

Signed-off-by: Josenivaldo Benito Jr <jrbenito@benito.qsl.br>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant