Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Forge) (Galacticraft) problems with galacticraft #46

Closed
fayer3 opened this issue May 1, 2017 · 12 comments
Closed

(Forge) (Galacticraft) problems with galacticraft #46

fayer3 opened this issue May 1, 2017 · 12 comments
Labels

Comments

@fayer3
Copy link

fayer3 commented May 1, 2017

in the planet selection GUI after launching a rocket or by the command /dimensiontp
there is no cursor.
Selecting a planet is very difficult without cursor.
using:
vivecraft 9r1
Galacticraft 1.11.2-4.0.0.80-BETA

edit:
also tested to open the Galaxy map with "M", there is also no cursor and it produces a graphical glitch on the left eye:
screenshot_thu_may_04_17-18-50_2017_vr

the map is also in front of the Hands.
I also reported this to the galacticraft devs: micdoodle8/Galacticraft#2675

@fayer3 fayer3 changed the title (Forge) (Galacticraft) no cursor in planet selection GUI (Forge) (Galacticraft) problems with galacticraft May 4, 2017
@jrbudda jrbudda added the Forge label May 5, 2017
@fayer3
Copy link
Author

fayer3 commented May 15, 2017

Since their build 82 it is not possible to use the Survival Inventory and the tab for the Galacticraft gear is not shown.
There are also some graphical glitches on the left eye: water not drawn, entities parts flying above the players head:
screenshot_thu_may_11_19-50-45_2017_vr
screenshot_thu_may_11_19-51-22_2017_vr

could this be caused by their switch to the GLStateManager?
micdoodle8/Galacticraft@51dd0cb
micdoodle8/Galacticraft@8e3a3ea

@jrbudda
Copy link
Owner

jrbudda commented May 15, 2017

Using glstatemanager should generally make things more compatible, not less, but I cant say for sure. Do the tabs show up if you turn 'menu background' on in the options?

@fayer3
Copy link
Author

fayer3 commented May 15, 2017

No, the menu Background doesn't change anything.
I also noticed, that items in the inventory are not shown.

@Techjar
Copy link
Collaborator

Techjar commented May 15, 2017

Looking at Galacticraft's source code... uh oh... transformEntityRenderer

@Techjar
Copy link
Collaborator

Techjar commented May 15, 2017

I've encapsulated Galacticraft's ClassTransformer, see what results you get this one.

vivecraft-1.11.2-jrbudda-10pre-installer.exe

@micdoodle8
Copy link

Hey, Galacticraft dev here. If you guys need us to make any changes to make GC more compatible with Vivecraft let me know. I don't have a Vive so I can't do much debugging myself but I'm happy to work with you guys to get things working.

@Techjar
Copy link
Collaborator

Techjar commented May 15, 2017

@micdoodle8 Awesome, thanks! I've looked at your ClassTransformer and I'm not sure if anything in there is interfering. You do inject code into stuff we modify though; the results from that encapsulated build should tell us if that's the problem. If it's not that, and I suspect it may not be, then debugging it will be significantly harder, as it would be some far more obscure call to some rendering related code. Probably some GL state nonsense.

@Techjar
Copy link
Collaborator

Techjar commented May 15, 2017

@micdoodle8 Oh, and if you want to debug with Vivecraft, you can install SteamVR and configure it to use the null driver, which will allow you to run it without an HMD. Simply put this in Steam/config/steamvr.vrsettings

{
    "jsonid" : "vrsettings",
    "steamvr": {
        "forcedDriver": "null"
    },
    "driver_null": {
        "enable": true,
        "id": "Null Driver",
        "serialNumber": "Null 4711",
        "modelNumber": "Null Model Number",
        "windowX": 100,
        "windowY": 100,
        "windowWidth": 1920,
        "windowHeight": 1080,
        "renderWidth": 1344,
        "renderHeight": 1512,
        "secondsFromVsyncToPhotons": 0.1,
        "displayFrequency": 90
    },
    "notifications" : {
        "DoNotDisturb" : false
    },
    "version" : "1"
}

@fayer3
Copy link
Author

fayer3 commented May 15, 2017

10pre doesn't change anything.
If it helps I noticed that in the log this error is repeated when the inventory is open:
[22:44:02] [Client thread/ERROR]: ########## GL ERROR ##########
[22:44:02] [Client thread/ERROR]: @ post 2d
[22:44:02] [Client thread/ERROR]: 1283: Stack overflow

@fayer3
Copy link
Author

fayer3 commented May 16, 2017

after some testing with the source code of Galacticraft it looks like this commit causes the non working inventory.
micdoodle8/Galacticraft@e45e658

@jrbudda
Copy link
Owner

jrbudda commented May 16, 2017

hmm, we do modify layerhelditem. I dont see how that code would cause a gl stack overflow tho unless something else is throwing an exception, will have to set up the mod and test it.

@fayer3
Copy link
Author

fayer3 commented May 18, 2017

the new Galacticraft build 91 partly fixes the rendering when the galaxy map is open, but there is still no cursor.
they also implemented a workaround for the tabs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants