Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mapped plugin relative paths break with commonjs require format #386

Closed
jrburke opened this issue Feb 19, 2013 · 1 comment
Closed

Mapped plugin relative paths break with commonjs require format #386

jrburke opened this issue Feb 19, 2013 · 1 comment
Milestone

Comments

@jrburke
Copy link
Member

jrburke commented Feb 19, 2013

Was requirejs/requirejs#640:

See test case here: The sample repo is here: https://github.com/guybedford/requirejs-plugin-map-bug

My notes from that ticket:

This is an interesting one. The cause: in node, there is an adapter module that provides a require.get() for synchronously loading a module, in case the request is for a node module that must be synchronously loaded. The problem line is here:
https://github.com/jrburke/r.js/blob/master/build/jslib/node.js#L62

and it is triggered by the require('coffee!./dep') call inside the module. However, .originalName, which is just the ./dep name, is called against the top level require, which ends up resolving relative to the baseUrl.

So, I need to reexamine that require.get() adapter. Another curious thing, the incoming moduleMap for that has an unnormalized module ID, but at that time the plugin should have already been loaded.

So, more investigation to do, but found the trigger. Marking for 2.1.5

@jrburke
Copy link
Member Author

jrburke commented Mar 1, 2013

Related, map use, from @tbranyen:

var requirejs = require("requirejs");

requirejs.config({
  map: {
    "*": {
      "jquery": "cheerio"
    }
  }
});

requirejs.define("test", function(require) {
  var $ = require("jquery");
});

requirejs(["test"]);

@jrburke jrburke closed this as completed in 9728e8a Mar 3, 2013
jrburke added a commit that referenced this issue Mar 3, 2013
jrburke added a commit to requirejs/requirejs that referenced this issue Mar 3, 2013
mikaelkaron added a commit to troopjs/troopjs that referenced this issue Mar 4, 2013
  > Relates to #656, comment typo
  > Relates to requirejs/r.js#386 and #656: pass localRequire to require.get, and fix typo
  > Merge branch 'master' of github.com:jrburke/requirejs
  > Fixes #655, fixes blog link
mikaelkaron added a commit to troopjs/troopjs that referenced this issue Mar 19, 2013
  > Merge pull request #666 from nofatclips/patch-1
  > Fixes #658, add more info about deps config option
  > Rev for 2.1.5
  > add mention of xpcshell
  > Fixes #642, trigger proper error paths if importScripts fails.
  > Fixes #647, mention no extension for paths config, point to paths fallbacks
  > Fixes #653, doc that map config works on absolute IDs.
  > Relates to #656, comment typo
  > Relates to requirejs/r.js#386 and #656: pass localRequire to require.get, and fix typo
  > Merge branch 'master' of github.com:jrburke/requirejs
  > Fixes #655, fixes blog link
  > Fixes #623, speed up checkLoaded by only checking enabled modules
  > Fixes #544, optimize normalize by not setting up map default
  > Fixes #625, remove erroneous omega listing, tested example and works.
  > Fixes #637, mention dependency IDs that do not get the baseUrl applied
  > rev version to indicate dev
  > Fixes #614, fix goofy toUrl hack with .fake
  > add main to package.json
  > Fixes #630, clarify onload function passed to plugin's load method.
  > update download page for jquery 1.9.1
  > add underscore shim for completeness
  > Refs #621, mention where the libs for shim config should be placed, and if not a shim config may be needed.
  > Merge pull request #620 from hamstu/master
  > typo
  > Merge pull request #613 from jrmlstf/patch-1
  > Rev for 2.1.4 release
  > MooTools does a build step instead
  > Merge pull request #607 from mostly-magic/master
  > fix jquery version ref
  > rev for 2.1.3
  > Fixes #587 and fixes #515, require.toUrl fixups including allowing ids without file extensions
  > Forgot to commit a test file, gitignore change
  > doc typo fixes
  > Fixes #603, missing comma
  > Fixes #563, be sure map is applied to resource IDs for plugins.
  > Fixes #583, call errbacks from load.fromText catch.
  > Merge pull request #594 from conradz/patch-1
  > Merge pull request #568 from guybedford/master
  > fix copy paste error in plugins.html for writeFile
  > Merge branch 'master' of github.com:jrburke/requirejs
  > clarify instructions around building require.js into a built file.
  > Update download.html page to match live site, jquery 1.8.3 in combined project now
  > Merge pull request #559 from Leestex/patch-1
  > Merge pull request #560 from stephenplusplus/master
  > Merge pull request #555 from riccieri/patch-1
  > fix test that relies too much on requirejs sync indosyncracies
  > update i18n test to pass locale setting via normal module config
  > update i18n test to pass locale setting via normal module config
  > rev for 2.1.2
  > Refs #525, add prototype to the test.
  > Fixes #540, do not allow later define calls to work after first one fully completes
  > Fixes #368, updates to optimizer doc page.
  > Fixes #531, show how a shimmed module is used.
  > Fixes #538, make sure module config passed to a transpiler plugin ID works before and after an inlining.
  > update dojo use status
  > Fixes #517, allow shim with an init but not exports.
  > Update sourcemap error message to indicate @license works for uglifyjs2 also.
  > Relates to requirejs/r.js#303, error message for incompatible options with generateSourceMaps
  > Merge pull request #530 from Ore4444/master
  > version plus to indicate more than 2.1.1
  > Relates to #525, more changes to make it ownprop tolerant
  > Relates to #525, allow own prop ids like toString
  > Fixes #519, bad plugins.html link
  > add info on publishing to nuget
Submodule src/lib/troopjs-jquery 383ca57..2499646:
  > Merge pull request #20 from lupincn/patch-2
mikaelkaron added a commit to troopjs/todomvc.troopjs.com that referenced this issue Apr 16, 2013
Submodule src/js/lib/troopjs-bundle 14d5bf7...1104751:
  > Submodule src/lib/troopjs-browser 18d05f4..f419671:   > storage.setItem does not return, yield original value.
  > Submodule resources/requirejs d998a42..b8fb39f:   > Merge pull request #702 from johtso/master   > Merge pull request #701 from sebm/patch-1
  > dist -> build
  > Exclude .dot(file|directory)
  > Submodule resources/requirejs ce30eda..d998a42:   > Fixes #669, if empty array for deps, do not do require,exports,module work   > Doc: for shim, mention local multifile builds have same restrictions as cdn builds. Submodule src/lib/when c7171b9..334e289:   > Bump version. Add Promises/A+ as keyword   > Merge pull request #136 from Narsul/master   > Remove keys/reduce from doc TOC
  > Submodule resources/requirejs 486941b..ce30eda:   > Fixes #681, mention string value for exports needed   > docs: clarify init return value not used for enforceDefine checking   > Merge pull request #673 from justlaputa/master Submodule src/lib/when 1f30cdd..c7171b9:   > Update text in ref to wire, thanks @scothis
  > Submodule src/lib/troopjs-core d227540..43769ef:   > be a bit safer when converting functions to strings.
  > Submodule src/lib/troopjs-browser 1ac4d8c..18d05f4:   > Update ajax service to return array of arguments. see troopjs/troopjs-core#98 Submodule src/lib/troopjs-core 72d9bb5..d227540:   > compare to UNDEFINED instead of falsy   > Only check if args is array if they were supplied Submodule src/lib/troopjs-data e709d53..0702318:   > Wrap done in apply (since ajax returns array of args now) Submodule src/lib/troopjs-utils c87cc95..60949ef:   > Safer merge with tests
  > Submodule src/lib/troopjs-core 56b6309..72d9bb5:   > Ensure handlers return arrays. Closes troopjs/troopjs-core#98
  > Submodule src/lib/when 64a37e0..1f30cdd:   > Fix #128. Add window.define.amd to legacy shim docs   > Merge debug helper for deferred.then   > Minor restructuring of util functions and capturing   > Capture all utils in a closure   > README tweak   > Streamlined coercion a bit   > Check for primitives and null/undefined   > Be more careful when accessing and calling untrustedThenable.then   > For now, keep the name isPromise   > Remove sauce-tests branch from travis now that it is merged   > Browser tests via @scothis test-support and saucelabs   > Better test for a *working* Object.defineProperty. Thanks @unscriptable   > Optimize deferred shape, better naming and jsdoc   > Remove focus rocket   > Add unit test for property access failure of thenable.then   > Safer assimilation, trap potential exceptions from getters/etc that may throw on simply property access to .then   > Update install instructions and Promises/A+ info   > Merge pull request #127 from scothis/browser-tests   > Make then() a little more readable, reduces code size slightly   > Use boolean guard instead of function replacement. In some JS engines (at least: v8, safari, ff), results in significant perf increase. Smaller, simpler code, too   > Update changelog with lift() info   > See #126. Use lift() in unit tests, add test to ensure bind aliases lift   > Close #126. Rename bind() to lift(), preserve deprecated bind() alias.   > Remove stowaway   > Seeing if Travis has recovered   > Add keys info to changelog   > JSHint tweaks   > Minor rephrasings based on feedback from @unscriptable   > Add link to promise.ensure docs. Update CHANGES   > Close #103. Implement promise.ensure, deprecate promise.always. API docs for ensure, switch unit tests to use ensure(done)   > Initial finally() implementation and unit tests   > Travis seems to be having trouble with node 0.9.  Disable for now   > Update to jshint 1.1. Still being careful with versions here until 1.x seems stable   > Update version numbers   > Minor comments   > Lighter weight promise internals using promises-aplus-like internal api   > Add unit tests to make sure we pass through progress events for when.map, delay, and timeout   > Remove docs for keys.reduce()   > See #30. Remove keys.reduce. In JS/ECMA, key enumeration order is not well-defined, making reduce a hazard   > Add docs and JSDoc   > See #30. when/keys module with all, map, and reduce   > Merge branch 'master' into dev   > Minor README tweak   > Minor comment reformat   > Remove when.chain docs. Minor tweaks. Discourage use of callback args in all, any, & some   > Trim changelog in README   > Update CHANGES, add promises/a+ link   > Remove dev-200 branch from travis. Fix README layout   > Merge branch 'dev-200' into dev   > Add Promises/A+ info, 2.0 changelog, update intro   > Minor code reformatting   > Remove deprecated methods from debug   > Minor naming and comment tweaks   > Fix next-tick assimilation test   > Fix jsdoc typo   > Merge branch 'dev' into dev-200   > Be careful to assimilate in a future tick, but always check isPromise and call untrusted then in the same tick as each other.  Add assimilation unit tests to verify   > Remove when.chain (deprecated in 1.8.1)   > Merge dev to dev-200   > Merge pull request #111 from Twisol/progress-promise   > Merge branch 'dev' into dev-200   > Remove unused var, thanks @Twisol   > Merge pull request #110 from Twisol/return-self-optimization   > Remove deprecated deferred.then, deferred.progress, deferred.resolver.progress   > Merge dev to dev-200   > Remove anti-starvation code. KISS until we have a evidence that we're too unfriendly to the tick queue   > Use lightweight promise to reject in chain(). Add warning about not completely trusting the resolver passed into chain()   > Merge 1.8.0 dev to dev-200   > Credit @Twisol for next-tick conflation idea   > Merge comma fixes from dev   > Merge latest dev. Update unit tests to account for asynchrony   > Merge dev   > Appease IE10 setImmediate   > Merge dev   > Merge branch 'dev' into dev-200   > Merge dev to dev-200   > Remove unnecessary level of indirection   > Merge branch 'dev' into dev-200   > Merge branch 'dev' into dev-200   > Minor code formatting tweak   > Remove configurability for now. Seems unnecessary now that the queueing is so fast, and works with wire.js   > After some thought and testing, switch back to previous chain() approach   > Protect chain() against undefined resolver.progress() method   > Configurable core promise API. More compact when.chain(). Clean up comments   > Merge branch 'async-resolutions' into dev-200
  > Updated package.version
  > Submodule resources/requirejs 30990c4..486941b:   > Merge pull request #666 from nofatclips/patch-1
  > Submodule src/lib/troopjs-browser 8df5090..1ac4d8c:   > don't delete $element reference. Closes troopjs/troopjs-dom#15
  > Submodule src/lib/troopjs-core 524f2e8..56b6309:   > Check that handled got set rather than the value of handled. Closes troopjs/troopjs-core#96.
  > Submodule src/lib/troopjs-jquery 5a3da73..621eeb4:   > Merge pull request #18 from normanzb/fix_length_mis_calculate
  > make maxi more maxi.
  > Submodule src/lib/when d384ae0..64a37e0:   > Merge pull request #125 from depeele/master
  > Submodule src/lib/troopjs-browser 0e24fed..8df5090:   > Don't add action plugin as default   > Simplified renderProxy   > Clean up comments   > Store both PROXY and VALUE for $handler
  > Submodule src/lib/troopjs-core 9fa0949..524f2e8:   > Merge pull request #95 from normanzb/test_signature_change
  > Submodule src/lib/troopjs-browser 79b5df7..0e24fed:   > remove $on/$off from internals   > Remove $on/$off/$trigger. Closes troopjs/troopjs-dom#14   > Fix comments Submodule src/lib/troopjs-jquery c6e33ec..5a3da73:   > Ensure that the destroy avent handler from the weave plugin is only added once.
  > Submodule src/lib/troopjs-browser 052cfe0..79b5df7:   > Refactor application widget to not use first arg. see troopjs/troopjs-core#94 Submodule src/lib/troopjs-core 4e33450..9fa0949:   > Don't pass first argument to signals. see troopjs/troopjs-core#94   > Fix result collection from signals
  > Submodule resources/requirejs 14b5837..30990c4:   > Fixes #658, add more info about deps config option   > Rev for 2.1.5   > add mention of xpcshell   > Fixes #642, trigger proper error paths if importScripts fails.   > Fixes #647, mention no extension for paths config, point to paths fallbacks   > Fixes #653, doc that map config works on absolute IDs.
  > Submodule src/lib/troopjs-browser 8e51d8a..052cfe0:   > Remove first argument from dom callback. See troopjs/troopjs-core#93   > Remove first argument from hub callback. See troopjs/troopjs-core#93 Submodule src/lib/troopjs-core d93c3ce..4e33450:   > Remove first argument from hub callback. See troopjs/troopjs-core#93 Submodule src/lib/troopjs-data 3cc4853..e709d53:   > Remove first argument from hub callback. See troopjs/troopjs-core#93
  > Submodule src/lib/troopjs-core e71fba5..d93c3ce:   > Test callback before .on. Closes troopjs/troopjs-core#91
  > Submodule resources/requirejs b44a1a3..14b5837:   > Relates to #656, comment typo   > Relates to requirejs/r.js#386 and #656: pass localRequire to require.get, and fix typo   > Merge branch 'master' of github.com:jrburke/requirejs   > Fixes #655, fixes blog link
  > Submodule resources/requirejs 248e45b..b44a1a3:   > Merge pull request #644 from cbourgois/patch-1 Submodule src/lib/troopjs-core 10c5c44..e71fba5:   > Merge pull request #90 from normanzb/develop   > Refactor off (again)   > Actually update handler[HANDLED]   > Actually, remove is what we want to call that label   > Change order of emit/reemit.   > Remember we changed the order of context and senile.   > Make context and callback optional in reemit   > Change order of arguments for 'reemit' and 'republish'.   > Rename 'remove' -> 'keep'   > Better implementation of off, both context and callback is now optional.   > Consistent naming of argsLength.   > Slice in wrong place.   > Really store handled   > Rename some variables   > Refactor event emitter to work with when.js 2.0. Closes troopjs/troopjs-core#87   > EventEmitter should make sure handler[CONTEXT][PHASE] is not initialize*|finalize*. Closes troopjs/troopjs-core#86   > Fix comments   > Override on/off/reemit on gadget to force context to `this`. Closes troopjs/troopjs-core#85 Submodule src/lib/troopjs-jquery 02f8424..c6e33ec:   > Add events on WEAVE/UNWEAVE. Closes troopjs/troopjs-jquery#17   > Lint fixes
  > Submodule src/lib/troopjs-core bdd66ab..10c5c44:   > Merge pull request #84 from normanzb/develop Submodule src/lib/troopjs-jquery 2edd9c8..02f8424:   > Replace when.chain as it's deprecated Submodule src/lib/when d339220..d384ae0:   > Minor doc tweaks   > Minor doc tweaks   > Minor README and changelog updates   > Add note about last 1.x release   > Update to and appease jshint 1.0   > Add deprecation warnings to README, docs   > Add deprecation warning for when.chain. Closes #113   > Remove usage of deferred.then   > Fix doc links, add doc changes to changelog   > update doc sections with some introductory text and add a few examples   > Merge branch 'master' into dev   > Make concelable tests more reliable   > Add test for untrusted thenable attempting to fulfill a promise with another promise   > Minor unit test reorg   > JSDoc   > Extract assimilation to its own function   > Back port safer progress wrapper for chain   > Add progress API deprecation to changelog   > Correct changelog   > Update version numbers, start changelog   > Merge branch 'dev' of github.com:cujojs/when into dev   > Close #106. Add deprecation notice for progress(), prefer notify()   > See #106. Deprecate progress(), add notify()
  > Submodule src/lib/troopjs-core 375eee7..bdd66ab:   > Add toString to Constructor. Closes troopjs/troopjs-core#83
  > Submodule src/lib/troopjs-jquery d2f1113..2edd9c8:   > All filters should use 'starts with'   > Unweave should be able to filter data-unweave attribute. Closes troopjs/troopjs-jquery#15
  > Submodule src/lib/troopjs-browser 33c69ef..8e51d8a:   > $emit -> $trigger
  > Submodule src/lib/troopjs-jquery 38a5cbc..d2f1113:   > Better implementation that protects the _same_ callback to be added more than once for destroy events.
  > Submodule src/lib/troopjs-jquery 0d80db4..38a5cbc:   > Prevent more than one onDestroy event to be added. Closes troopjs/troopjs-jquery#16   > Fix .woven to behave like before
  > Submodule src/lib/troopjs-jquery d4e899c..0d80db4:   > Filter promises for .woven. Closes troopjs/troopjs-jquery#14
  > Submodule src/lib/troopjs-core 760599d..375eee7:   > Remember when args are mutated. Closes troopjs/troopjs-core#82
  > Submodule src/lib/troopjs-jquery 536a541..d4e899c:   > Be safer when using getargs
  > Submodule src/lib/troopjs-core 2a4ad9d..760599d:   > Don't store result for negative index   > Return result from signal execution
  > Submodule resources/requirejs 5736b99..248e45b:   > Fixes #623, speed up checkLoaded by only checking enabled modules   > Fixes #544, optimize normalize by not setting up map default   > Fixes #625, remove erroneous omega listing, tested example and works.   > Fixes #637, mention dependency IDs that do not get the baseUrl applied   > rev version to indicate dev   > Fixes #614, fix goofy toUrl hack with .fake   > add main to package.json Submodule src/lib/troopjs-core 099066e..2a4ad9d:   > Add support to emit either in sequence or pipeline. Closes troopjs/troopjs-core#81 Submodule src/lib/when 46b5fe4..d339220:   > Add dev-200 branch to travis whitelist
  > Submodule src/lib/troopjs-jquery aae248e..536a541:   > Merge branch 'feature/fix-weave' into develop
  > Submodule src/lib/troopjs-core 956c2d4..099066e:   > Fix where to slice for subscribe|unsubscribe|republish.
  > Submodule src/lib/troopjs-core bd43b78..956c2d4:   > Fix gadget.(subscribe|unsubscribe|publish|republish). Closes troopjs/troopjs-core#80 Submodule src/lib/troopjs-utils 575acba..c87cc95:   > Lint fixes
  > Submodule src/lib/troopjs-core f3d3089..bd43b78:   > Lint fixes Submodule src/lib/troopjs-jquery da903e0..aae248e:   > Better .unweave   > Better .woven   > Testing new implementation of .weave (.unweave is broken here.. be ware) Submodule src/lib/troopjs-utils 41534b3..575acba:   > Added filter
  > Submodule src/lib/troopjs-core 6d8db63..f3d3089:   > Fix stupid merge bug   > Know what, we can increase handled once we know there are handlers...
  > Submodule resources/requirejs a54b692..5736b99:   > Fixes #630, clarify onload function passed to plugin's load method. Submodule src/lib/troopjs-browser 9ef72d8..33c69ef:   > Topic is not useful enough to keep. Kill it. Submodule src/lib/troopjs-core 98d184b..6d8db63:   > Topic is not useful enough to keep. Kill it.   > Fix super awesome concurrency problem (stupid Mike). Fixes troopjs/troopjs-core#78   > Use .create Submodule src/lib/troopjs-data 8f629c5..3cc4853:   > Topic is not useful enough to keep. Kill it.
  > Submodule src/lib/troopjs-core 5361d8b..d383598:   > Fix .create. Closes troopjs/troopjs-core#70 (again)
  > Submodule src/lib/troopjs-core 6546899..5361d8b:   > Add senility support to event/emitter. Closes troopjs/troopjs-core#77   > Add support for more detailed phase(s). See troopjs/troopjs-core#54   > Better way to wait for reemit to finish   > Add PHASE support for components Submodule src/lib/troopjs-jquery 08f3069..da903e0:   > Further optimization of expressions   > Optimize expressions.   > fix typo   > tabbing   > Array.map vs. $.map   > Use constants
  > Submodule src/lib/troopjs-browser acab95f..9ef72d8:   > Rename _toString -> URIToString
  > Submodule src/lib/troopjs-core c226f90..6546899:   > .configure returns current configuration. Closes troopjs/troopjs-core#75 Move .configure to base. Closes troopjs/troopjs-core#76   > Event emission does not need to try {} catch {}.
  > Submodule src/lib/troopjs-browser 44ef051..acab95f:   > handlers->specials (to mirror gadget) Submodule src/lib/troopjs-core c274218..c226f90:   > Fixed signaling non-existing signal. Closes troopjs/troopjs-core#74
  > Add poly to buster requirejs setup
  > Submodule src/lib/troopjs-core 17a5cda..c274218:   > lint fixes   > Fix decorators not handling no previous value to decorate. Closes troopjs/troopjs-core#73 Adjust around decorator to work like ComposeJS. Closes troopjs/troopjs-core#72
  > Submodule src/lib/troopjs-browser 45ddfe2..44ef051:   > Use service registry for storing services. Closes troopjs/troopjs-dom#13 Submodule src/lib/troopjs-core d377551..17a5cda:   > Allow service registry to be interacted with via instance   > Simplify signal
  > Submodule src/lib/troopjs-browser e1e89fe..45ddfe2:   > Application widget should create registry service   > Signals should not pipe arguments Submodule src/lib/troopjs-core a3c5613..d377551:   > Initial implementation of service registry   > Add .configure to component/service Add/remove on sig/initialize and sig/finalize (from service registry)   > Signals should not pipe arguments Submodule src/lib/troopjs-data a469476..8f629c5:   > Refactor how the query service is configured Submodule src/lib/when 5eb8795..46b5fe4:   > Fix CHANGES links   > Fix doc links   > louder kudos   > Remove extra paren in README & CHANGES   > Update copyright   > Update copyright   > Add links to changelog   > Finish unfold examples and text   > Add unfold example code   > Minor cleanup   > Remove focus rocket   > Simplify test/poll a bit   > Allow poll interval function to return a promise   > Almost done with unfold docs   > Docs for when/unfold/list   > Revise unfold to use the more typical unspool approach of returning a pair   > Docs for when/poll. Started docs for unfold   > Doc stubs for when/poll and when/unfold   > Bump version and update changelog   > Remove trailing commas   > Cherry pick async-proof changes to callbacks unit test from dev-200 branch   > Merge branch 'master' into dev   > Merge branch 'throw-reject-verbatim' into dev   > Merge README link hotfix   > Merge pull request #99 from riccieri/functional-docs   > Merge pull request #98 from riccieri/patch-1   > Merge branch 'master' into dev   > README clarifications   > Update README for 1.8 release. Add node 0.9 to travis   > Merge pull request #93 from riccieri/callback   > Sadly return to status quo for deferred.reject. Promises/A+ is still debating polymorphic reject.   > Minor cleanup of umd boilerplate, comments. Remove unused nextTick module for now   > Merge branch 'functional' into dev   > See #91. deferred.reject(promise) now rejects with the eventual value/reason of promise regardless of whether promise fulfills or rejects   > Remove duplicate test   > Fix #88. Throwing a promise rejects with the eventual value/reason of the thrown promise   > Unit test coverage for exceptions in unfold. Streamlining and cleanup. Unit tests for unfold/list   > Split unfold and unfold list. Add more unfold unit tests   > Starting unit tests for unfold   > jsdoc and name tweaks   > Refinements to unfold. proceed test is applied first   > Initial promise-based unfold+map: seed can be a promise, generator and transform may return promises   > Ensure that deferred.progress does not reveal the state of deferred.promise   > Fix #89. Quote yield to avoid SyntaxError in Android browser   > Fix browser test setup for parallel and sequence   > JSDoc fix   > Removing straggler deferred.then usages   > Add jshintignore   > Remove no-longer-applicable TODO   > Minor unit test reorg   > As per Promises/A+, ignore non-functions.  Unit tests   > Minor cleanup   > Merge pull request #83 from scothis/poll
  > Submodule src/lib/troopjs-core cdbce36..a3c5613:   > Add around advise. Fix some typos. Reverse order in before/after advise.
  > Submodule src/lib/troopjs-core 589300f..cdbce36:   > Add before/after advice to factory. Closes troopjs/troopjs-core#69   > Add support for Factory.create and Constructor.create. Closes troopjs/troopjs-core#70
  > Merge branch 'release/2.0.0'
  > Merge branch 'release/1.0.7'
  > Merge branch 'release/1.0.6'
  > Merge branch 'release/1.0.5'
  > Merge branch 'release/1.0.4'
  > bumped troopjs-core
  > Merge branch 'release/1.0.3'
  > bumped troopjs-core
  > Added VERSION
  > bumped troopjs-core
  > bumped troopjs-core
  > bumped requirejs
  > use https vs git protocol for submodules
  > bumped requirejs
  < Merge branch 'release/1.0.1'
  < snapshot
  < bumped troopjs-core to 1.0.1
  < use https vs git protocol for submodules
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant