-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IsVerified can't protect api routes #97
Comments
Hi @osaris Is that fixing your issue? |
Looking at your commit here 2cdf8fe i think it won't fix my issue because there won't be error anymore but no check is done anymore in the case of an API call ? |
So I don't understand your question neither your request.
What do you suggest? Please share your thoughts + code sample
… On Jan 16, 2017, at 2:11 AM, Raphaël Emourgeon ***@***.***> wrote:
Looking at your commit here 2cdf8fe i think it won't fix my issue because there won't be error anymore but no check is done anymore in the case of an API call ?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the thread.
|
Sorry I have no code sample but the problem is that API guard doesn't set $request->user. Your patch doesn't provide an alternative to check if the current $user is verified, it simply doesn't do the check if $user is null. I wasn't able to find a good code to do check for both web/api guard (and custom user guard ?) user. But the problem is mentionned here for example : laravel/framework#11782 (comment) |
Sorry I don't understand what is your issue then. |
Hello,
I can't reject API call if user isn't verified by adding the middleware
ìsVerified
to my api routes because this linelaravel-user-verification/src/Middleware/IsVerified.php
Line 25 in c798f80
Regards
The text was updated successfully, but these errors were encountered: