Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent definition of initial conditions for multilayer tidal shooting method #31

Closed
5 tasks
jrenaud90 opened this issue Dec 2, 2021 · 1 comment
Closed
5 tasks
Labels
Beginner Issue is good for newcomers to TidalPy Question Further information is requested Research Needed Research is required to address this issue

Comments

@jrenaud90
Copy link
Owner

There is a mismatch in definitions between TS72 Eq. 99 (Takeuchi, H., and M. Saito (1972), Seismic surface waves, Methods Comput. Phys., 11, 217–295.) and KMN15 Eq. B13 (Kamata+ (2015; JGR-P; DOI: 10.1002/2015JE004821)) for the initial guess used in the shooting method for solid layers. TS72 has a "minus/plus" for k2 whereas KMN has a "plus/minus" basically flipping solution 1 and 2.

  • Check if this makes a difference to begin with (try flipping solution 1 and solution 2)
  • If it does then try to determine which is correct
  • Update code and TODOs at:
    • Around line 90 and 314 in tides.multilayer.numerical_int.initial_solution_dynamic.py
    • Around line 90 and 216 in tides.multilayer.numerical_int.initial_solution_static.py
@jrenaud90 jrenaud90 added Question Further information is requested Beginner Issue is good for newcomers to TidalPy Research Needed Research is required to address this issue labels Dec 2, 2021
@jrenaud90
Copy link
Owner Author

Duplicate of #43

@jrenaud90 jrenaud90 marked this as a duplicate of #43 Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Beginner Issue is good for newcomers to TidalPy Question Further information is requested Research Needed Research is required to address this issue
Projects
None yet
Development

No branches or pull requests

1 participant