Print drmingw version in a crash report.

[dismine]

What do you think about idea print in a crash report current drmingw version number? I think it will useful know which version generated report especially when we speak about debugging drmingw itself.

[renatosilva]

It would also be interesting to include version information for the application too, like implemented here.

[White-Tiger]

that's quite a good idea and simplifies bug reports from users (it's quite common that not every user is always using the latest version)

Though, does anyone know why "Daniel Atallah" used ZeroMemory in these 2 cases?

LPVOID pVer = malloc(size);
ZeroMemory(pVer, size);

OSVERSIONINFO osvi;
ZeroMemory(&osvi, sizeof(OSVERSIONINFO));
osvi.dwOSVersionInfoSize = sizeof(OSVERSIONINFO);

I guess this would be a cleaner way of doing it:

LPVOID pVer = calloc(size, 1);

OSVERSIONINFO osvi = {sizeof(OSVERSIONINFO)};

[jrfonseca]

It would also be interesting to include version information for the application too, like implemented here.

@renatosilva It seems a good enhancement. Could you please rebase the patch -- it would need to be re-applied to src/common/log.c -- and file a separate issue (maybe a pull request)?

[jrfonseca]

What do you think about idea print in a crash report current drmingw version number? I think it will useful know which version generated report especially when we speak about debugging drmingw itself.

@dismine I don't feel strongly either way (not sure if it would be useful or distracting.) Could you give an example of what you had in mind?

[dismine]

Could you give an example of what you had in mind?

Some time ago i tried debug my program because got many crash reports from users. Reason for these reports was false alarm crashes. After you fixed them (not all i think) i still get reports from old versions. But because i can't determine drmingw version i will spend more time trying understand is it fixed false alarm report or not. For me debugging my program it is also debugging drmingw.

Also have version number in crash report will cause less questions about used drmingw version in that case.

[jrfonseca]

@dismine, Right, I understand where you're coming from.

My question was more in practical terms: where should the version appear and how should be printed.

For example, would a

Report done written by ExcHndl X.Y.Z.

line at the end work, or should it be something less conspicuous like

DrMinGW X.Y.Z

(I don't actually use ExcHndl myself. Nowadays I only use DrMinGW itself.)

[dismine]

I like second

DrMinGW X.Y.Z