Skip to content
This repository has been archived by the owner on Jul 1, 2024. It is now read-only.

Proper location for the binary #18

Closed
cmsj opened this issue Jan 27, 2016 · 3 comments
Closed

Proper location for the binary #18

cmsj opened this issue Jan 27, 2016 · 3 comments

Comments

@cmsj
Copy link
Contributor

cmsj commented Jan 27, 2016

It seems to be fairly unconventional to store the unlock binary in /Library/LaunchDaemons/. Given that homebrew sets crazy permissions on many /usr/local/ directories, and all of /System and /sbin are locked down by SIP, perhaps /Library/PrivilegedHelperTools/ would be a reasonable place to put the binary?

@jridgewell
Copy link
Owner

Given that homebrew sets crazy permissions on many /usr/local/ directories

We run as root during install, so that shouldn't be an issue. Want to open a PR?

@tjluoma
Copy link

tjluoma commented Jan 27, 2016

Installers that write to /usr/local/bin/ work fine with Homebrew as long as it doesn't change ownership or permissions of that directory.

On Jan 27, 2016, at 3:48 PM, Justin Ridgewell notifications@github.com wrote:

Given that homebrew sets crazy permissions on many /usr/local/ directories

We run as root during install, so that shouldn't be an issue. Want to open a PR?


Reply to this email directly or view it on GitHub.

@cmsj
Copy link
Contributor Author

cmsj commented Jan 27, 2016

To be clear, I'm not saying that homebrew's permissions make it tricky to install in /usr/local, I'm saying that they make it inappropriate to install anything in there which will be run as root, on boot :)

jridgewell added a commit that referenced this issue Jan 27, 2016
Change binary installation location to /Library/PrivilegedHelperTools/. Closes #18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants