-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding a CONTRIBUTING.md #47
Comments
Hi @AndreasBackx ,
This of course also applies to docstrings:
About the line length, I follow the guideline from Django, which allows 119 characters, but I use a soft limit of 100, which means that I try to stay below, if otherwise I would have to use a I fully agree, that this should be added to a contributing file. |
Good to know that you use that quoting style. I don't really mind and will do what has been done in the past on the project. Mine were only suggestions in case there weren't any. I would also suggest using isort for imports. |
No |
I noticed that in the project single and double quotes are used interchangeably. (The majority is single quotes it seems.) This together with adding documentation would be beneficial to the project and I think we should start put all of this information in
CONTRIBUTING.md
so we and other can refer to it.The choice for docstrings is Numpy or Google style? I've always used the Google one, what do you think?
Then I would just say that the code has to conform with PEP8 but not with the max 80 character rule. Rather I would say conform with a ~90 char rule. I would love to refer you to this talk from Raymond Hettinger about PEP8 that talks about this.
The text was updated successfully, but these errors were encountered: