Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Light refactor #2

Merged
merged 8 commits into from Dec 27, 2020
Merged

Light refactor #2

merged 8 commits into from Dec 27, 2020

Conversation

chrieke
Copy link
Collaborator

@chrieke chrieke commented Dec 26, 2020

No logic changes, makes main script more readable & separates creating the content to display & displaying it in streamlit (Relevant for readability, display formatting changes, (tests)).

@chrieke chrieke requested a review from jrieke December 26, 2020 23:20
@jrieke
Copy link
Owner

jrieke commented Dec 27, 2020

Looks good. What about merging content.py and tweet_templates.py into one file (they basically do the same stuff/rely on each other anyway)?

E.g. name this file templates.py, then you can do (in the main file) tweet = templates.construct_tweet(stats), and everything for this function is in templates. Or we could even rename the functions to make it a bit more Pythonic, e.g. tweet = templates.tweet(stats) and templates.tweet_button(tweet).

@jrieke jrieke merged commit 8a1bd3c into main Dec 27, 2020
@chrieke chrieke deleted the light_refactor branch January 3, 2021 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants