Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DynamicsLoss does not use z_pred_loss while training #4

Open
famishedrover opened this issue Jun 29, 2023 · 0 comments
Open

DynamicsLoss does not use z_pred_loss while training #4

famishedrover opened this issue Jun 29, 2023 · 0 comments

Comments

@famishedrover
Copy link

When compute_dynamics_loss is called in world_model.py, it is fed in an argument called preds returned from dyn_model.predict(). For z prediction, preds have keys z_dist and z_hat_probs and there is no key z.

When computing the dynamics loss, specifically the loss for z, the code checks for whether z is in the list of keys preds which it never is (because the keys are z_dist and z_hat_probs). For this reason the z_pred_loss is never computed & used for training.

A fix should be made here, something like :

if 'z_dist' in preds: ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant