Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detaching a part with KIS causes a nullref #494

Closed
henrybauer opened this issue Mar 19, 2016 · 2 comments
Closed

Detaching a part with KIS causes a nullref #494

henrybauer opened this issue Mar 19, 2016 · 2 comments
Labels
Milestone

Comments

@henrybauer
Copy link

[LOG 20:19:59.207] Set pointer mode to: Drop
[LOG 20:20:00.078] Move part
[ERR 20:20:00.081] System.Collections.Generic.KeyNotFoundException: The given key was not present in the dictionary.
  at System.Collections.Generic.Dictionary`2[System.UInt32,System.Collections.Generic.KeyValuePair`2[ContractConfigurator.Parameters.VesselParameter+ParamStrength,System.Double]].get_Item (UInt32 key) [0x00000] in <filename unknown>:0 
  at ContractConfigurator.Parameters.VesselParameter.OnPartJointBreak (.PartJoint p) [0x00000] in <filename unknown>:0 
  at ContractConfigurator.Parameters.PartValidation.OnPartJointBreak (.PartJoint p) [0x00000] in <filename unknown>:0 
  at EventData`1[PartJoint].Fire (.PartJoint data) [0x00000] in <filename unknown>:0 
  at PartJoint.DestroyJoint () [0x00000] in <filename unknown>:0 
  at Part.decouple (Single breakForce) [0x00000] in <filename unknown>:0 
  at KIS.KIS_Shared.DecoupleAssembly (.Part assemblyRoot) [0x00000] in <filename unknown>:0 
  at KIS.KISAddonPickup.MoveDrop (.Part tgtPart, Vector3 pos, Quaternion rot) [0x00000] in <filename unknown>:0 
  at KIS.KISAddonPickup.OnPointerAction (PointerTarget pointerTarget, Vector3 pos, Quaternion rot, .Part tgtPart, System.String srcAttachNodeID, .AttachNode tgtAttachNode) [0x00000] in <filename unknown>:0 
  at KIS.KISAddonPointer.UpdatePointer () [0x00000] in <filename unknown>:0 
  at KIS.KISAddonPointer.Internal_Update () [0x00000] in <filename unknown>:0 
  at KSPDev.LoggedCallWrapper.Action (System.Action action) [0x00000] in <filename unknown>:0 

[LOG 20:20:23.528] Move part
[ERR 20:20:23.530] System.Collections.Generic.KeyNotFoundException: The given key was not present in the dictionary.
  at System.Collections.Generic.Dictionary`2[System.UInt32,System.Collections.Generic.KeyValuePair`2[ContractConfigurator.Parameters.VesselParameter+ParamStrength,System.Double]].get_Item (UInt32 key) [0x00000] in <filename unknown>:0 
  at ContractConfigurator.Parameters.VesselParameter.OnPartJointBreak (.PartJoint p) [0x00000] in <filename unknown>:0 
  at ContractConfigurator.Parameters.PartValidation.OnPartJointBreak (.PartJoint p) [0x00000] in <filename unknown>:0 
  at EventData`1[PartJoint].Fire (.PartJoint data) [0x00000] in <filename unknown>:0 
  at PartJoint.DestroyJoint () [0x00000] in <filename unknown>:0 
  at Part.decouple (Single breakForce) [0x00000] in <filename unknown>:0 
  at KIS.KIS_Shared.DecoupleAssembly (.Part assemblyRoot) [0x00000] in <filename unknown>:0 
  at KIS.KISAddonPickup.MoveDrop (.Part tgtPart, Vector3 pos, Quaternion rot) [0x00000] in <filename unknown>:0 
  at KIS.KISAddonPickup.OnPointerAction (PointerTarget pointerTarget, Vector3 pos, Quaternion rot, .Part tgtPart, System.String srcAttachNodeID, .AttachNode tgtAttachNode) [0x00000] in <filename unknown>:0 
  at KIS.KISAddonPointer.UpdatePointer () [0x00000] in <filename unknown>:0 
  at KIS.KISAddonPointer.Internal_Update () [0x00000] in <filename unknown>:0 
  at KSPDev.LoggedCallWrapper.Action (System.Action action) [0x00000] in <filename unknown>:0 

[LOG 20:20:24.930] Cancel key pressed, stop eva attach mode
[LOG 20:20:24.930] StopPointer(pointer)

@henrybauer
Copy link
Author

Reverting to 1.9.8 fixes this.

Sure looks like it's caused by the removal of null checking in this commit:

de03094#diff-0b98b274c930f8024fca074feeb72589L452

@jrossignol
Copy link
Owner

Fixed for next release.

@jrossignol jrossignol added the bug label Mar 20, 2016
@jrossignol jrossignol added this to the 1.9.10 milestone Mar 20, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants