Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jolt.h inclusion indirectly disables warnings in project code #107

Closed
ifiddynine opened this issue Mar 28, 2022 · 4 comments
Closed

Jolt.h inclusion indirectly disables warnings in project code #107

ifiddynine opened this issue Mar 28, 2022 · 4 comments

Comments

@ifiddynine
Copy link
Contributor

ifiddynine commented Mar 28, 2022

First of all, Jolt is amazing. We switched over from PhysX recently and it's ❤. Thank you for this initiative!

Now to the issue, Jolt/Core/Core.h leaks disabled / ignored warnings into user code: https://github.com/jrouwe/JoltPhysics/blob/master/Jolt/Core/Core.h#L25 We found this out by noticing some expected warnings weren't treated as errors anymore after switching to Jolt.

We're working around this on our end, but I'm not sure what the preferred fix for the project would be. One way is changing to pragma push / pop, but that requires adding an "end" header to include after all of Jolt includes in user code.

The ideal change would likely be to only ignore these warnings where they occur instead of globally, using push / pop in the relevant functions.

@jrouwe
Copy link
Owner

jrouwe commented Mar 28, 2022

Hello,

I was already wondering when someone would ask :)

With #108 the pragmas should no longer leave the Jolt headers.

Regards,

Jorrit.

@ifiddynine
Copy link
Contributor Author

Heyo.

Awesome. That was quick haha, thank you very much!

@jrouwe
Copy link
Owner

jrouwe commented Mar 28, 2022

Not everything passed the compiler unfortunately. MSVC is weird with warnings. Fixing it now.

@jrouwe
Copy link
Owner

jrouwe commented Mar 28, 2022

Changes merged into master.

@jrouwe jrouwe closed this as completed Mar 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants