You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We're working around this on our end, but I'm not sure what the preferred fix for the project would be. One way is changing to pragma push / pop, but that requires adding an "end" header to include after all of Jolt includes in user code.
The ideal change would likely be to only ignore these warnings where they occur instead of globally, using push / pop in the relevant functions.
The text was updated successfully, but these errors were encountered:
First of all, Jolt is amazing. We switched over from PhysX recently and it's ❤. Thank you for this initiative!
Now to the issue, Jolt/Core/Core.h leaks disabled / ignored warnings into user code: https://github.com/jrouwe/JoltPhysics/blob/master/Jolt/Core/Core.h#L25 We found this out by noticing some expected warnings weren't treated as errors anymore after switching to Jolt.
We're working around this on our end, but I'm not sure what the preferred fix for the project would be. One way is changing to pragma push / pop, but that requires adding an "end" header to include after all of Jolt includes in user code.
The ideal change would likely be to only ignore these warnings where they occur instead of globally, using push / pop in the relevant functions.
The text was updated successfully, but these errors were encountered: