Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider using pre-commit or equivalent to prevent unformatted (and untested?) code from being checked in #216

Open
jbduncan opened this issue Jul 26, 2018 · 3 comments

Comments

@jbduncan
Copy link
Contributor

See https://github.com/pre-commit/pre-commit for more info.

@jbduncan jbduncan changed the title Consider using pre-commit or equivalent to prevent un-Spotless-ified code from being checked in Consider using pre-commit or equivalent to prevent unformatted (and untested?) code from being checked in Jul 26, 2018
@jbduncan
Copy link
Contributor Author

This issue is a follow-on to #214 (comment)

@jbduncan
Copy link
Contributor Author

jbduncan commented Jul 26, 2018

@jrtom Out of curiosity, do you use any tools at Google, internal or otherwise, which prevent code from being checked in at the client side before tests/checks pass? If these tools are open to non-Googlers, could we use them instead of pre-commit?

@jbduncan
Copy link
Contributor Author

This also makes me want to ask: are there any other tools and development practices you take for granted at Google that we could aim to incorporate here or find alternatives for to make GitHub a more pleasant experience?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant