Import broken in latest beta

[henryruhs]

Import via 3.0.0-beta.2 is broken as of missing index.js file.

Current import workaround:

import Cookies from 'js-cookie/dist/js.cookie';

Solution via node_modules/js-cookie/index.js:

module.exports = require('./dist/js.cookie');

or

module.exports = {
    Cookies: require('./dist/js.cookie');
};

Desired import:

import Cookies from 'js-cookie';

[FagnerMartinsBrack]

Can you write a test reproducing the issue so that we can guard against regression?

[henryruhs]

An import issue is not testable... especially for a dist that has been build.

[FagnerMartinsBrack]

@redaxmedia

There is a test for ES6 import already here. What's the difference between the way you're using and they way it's being tested?

Could it be that we need a test for importing cookies from the root of the package so that it can trigger the need for the "main" field on package.json?

package.json:

{
  "main": "./dist/js.cookie"
}

[henryruhs]

Nope, this test does not take care of the dist package released on NPM. Just checkout the beta via npm install and try to import it inside a JavaScript file. I cannot provide more help at this point.

[carhartl]

Also see: #544 (comment)

[henryruhs]

@carhartl I opened another issue cause this has nothing todo with the testing setup. Never mix up issues on one task / branch.

[carhartl]

@redaxmedia Aye aye. It looked like it could be the same issue, but you seem to know better.

[carhartl]

I‘m still confused as to how the index.js relates to the browser field in the package definition. Also, should index.js point to the es6 or umd dist variant. Can’t seem to find good answers on the internet.

[carhartl]

Slightly different advice here: #544 (comment)

[carhartl]

@redaxmedia I've added an example where I've tested (in Nodejs 13.2.0) that this issue is now fixed, but could you also please give it a try...

[henryruhs]

Finally, I can confirm that 3.0.0-beta.3 works again.