DSUtils.removeCircular is removing more stuff than it should

[kentcdodds]

Here are some examples:

[kentcdodds]

Here's the transpiled version of that function that I'm using which results in this:

function removeCircular(object) {
  var objects = [];

  return (function rmCirc(value) {

    var i = undefined;
    var nu = undefined;

    if (typeof value === "object" && value !== null && !(value instanceof Boolean) && !(value instanceof Date) && !(value instanceof Number) && !(value instanceof RegExp) && !(value instanceof String)) {

      for (i = 0; i < objects.length; i += 1) {
        if (objects[i] === value) {
          return undefined;
        }
      }

      objects.push(value);

      if (DSUtils.isArray(value)) {
        nu = [];
        for (i = 0; i < value.length; i += 1) {
          nu[i] = rmCirc(value[i]);
        }
      } else {
        nu = {};
        forOwn(value, function (v, k) {
          return nu[k] = rmCirc(value[k]);
        });
      }
      return nu;
    }
    return value;
  })(object);
}

[jmdobry]

and the function as it was added in 1.1.0

function removeCircular(object) {
  var objects = [];

  return (function rmCirc(value) {

    var i;
    var nu;

    if (typeof value === 'object' && value !== null && !(value instanceof Boolean) && !(value instanceof Date) && !(value instanceof Number) && !(value instanceof RegExp) && !(value instanceof String)) {

      for (i = 0; i < objects.length; i += 1) {
        if (objects[i] === value) {
          return undefined;
        }
      }

      objects.push(value);

      if (DSUtils.isArray(value)) {
        nu = [];
        for (i = 0; i < value.length; i += 1) {
          nu[i] = rmCirc(value[i]);
        }
      } else {
        nu = {};
        forOwn(value, function (v, k) {
          nu[k] = rmCirc(value[k]);
        });
      }
      return nu;
    }
    return value;
  }(object));
}

[jmdobry]

I think I figured it out. It's this:

Original ES5:

forOwn(value, function (v, k) {
  nu[k] = rmCirc(value[k]);
});

New ES6: forOwn(value, (v, k) => nu[k] = rmCirc(value[k]));
Transpiled ES5:

forOwn(value, function (v, k) {
  return nu[k] = rmCirc(value[k]);
});

The forOwn function will stop iteration if false is returned. The transpiled code has a return, while the original ES5 does not. You found this because your JSON has a key with a false value. The fix is easy enough.