Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

js2-minor-mode - keymap not defined #53

Closed
niklasfasching opened this issue Apr 11, 2015 · 2 comments
Closed

js2-minor-mode - keymap not defined #53

niklasfasching opened this issue Apr 11, 2015 · 2 comments

Comments

@niklasfasching
Copy link

Is there a reason the keys are added exclusively to the js2-mode-map?
If js2-refactor also works when only using the js2-minor-mode, it would make sense to set up keybindings there as well.

@NicolasPetton
Copy link
Collaborator

Nupf writes:

Is there a reason the keys are added exclusively to the js2-mode-map?
If js2-refactor also works when only using the js2-minor-mode, it
would make sense to set up keybindings there as well.

My plan is to make js2r a minor-mode. It should fix your problem.

@NicolasPetton
Copy link
Collaborator

Should be fixed now that #54 has been merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants