Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add French translation + buttons #15

Merged
merged 3 commits into from Mar 22, 2017
Merged

Add French translation + buttons #15

merged 3 commits into from Mar 22, 2017

Conversation

Poussinou
Copy link
Contributor

this PR adds the french translation (you can notify me in the future if there is any new key to translate)

This also adds two buttons with links to google play and fdroid

@js-labs
Copy link
Owner

js-labs commented Mar 22, 2017

Hi!
Thank you for PR!
+ <string name="app_name">Talkie Walkie Wifi</string>
Is it really necessary to change app name? :)

@Poussinou
Copy link
Contributor Author

Maybe I can change it to Wifi Talkie Walkie, but if you want to complain with french vocabulary, you couldn't change Talkie Walkie. In English we say Walkie Talkie, but the reverse in French.

You can also leave the english name, everybody in France will understand. Choice is yours ;)

@js-labs
Copy link
Owner

js-labs commented Mar 22, 2017

Ok, I see
I thought French is not so different :)

@js-labs js-labs merged commit 70047bc into js-labs:master Mar 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants