Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate: map netlify.com to netlify.app #25

Closed
MattIPv4 opened this issue Sep 5, 2023 · 0 comments
Closed

Validate: map netlify.com to netlify.app #25

MattIPv4 opened this issue Sep 5, 2023 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@MattIPv4
Copy link
Member

MattIPv4 commented Sep 5, 2023

https://github.com/js-org/js.org/pull/8480 migrated all netlify.com usage to netlify.app, and as such we should update the CNAME parsing logic in validation/cleanup to automatically map netlify.com subdomains to netlify.app, similar to how we map Vercel subdomains.

// Convert vercel.app to cname.vercel-dns.com
if (target.endsWith('.vercel.app')) target = 'cname.vercel-dns.com';

@MattIPv4 MattIPv4 added enhancement New feature or request good first issue Good for newcomers labels Sep 5, 2023
@MattIPv4 MattIPv4 closed this as completed Sep 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant