Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 87 - Added fs.fsync() as a no-op, and added tests. Modified docume... #176

Closed
wants to merge 3 commits into from
Closed

Conversation

kwkofler
Copy link
Contributor

...ntation.

@@ -720,7 +720,7 @@ fs.open('/myfile.txt', function(err, fd) {

#### fs.fsync(fd, callback)<a name="fsync"></a>

NOTE: Not yet implemented, see https://github.com/js-platform/filer/issues/87
NOTE: Currently implemented as a no-op. Will error if a file descriptor is invalid or if the descriptor is not opened in a write context, but otherwise returns an empty callback.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This comment is unnecessary.

@humphd humphd mentioned this pull request Dec 2, 2018
@humphd
Copy link
Contributor

humphd commented Dec 2, 2018

Taking this over the line in #593. Sorry these got stalled @kwkofler, thanks for doing them.

@humphd humphd closed this Dec 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants