Skip to content
This repository has been archived by the owner on Oct 20, 2020. It is now read-only.

Add class name prefixes to fix potential style leaks #29

Closed
rbrtsmith opened this issue May 24, 2017 · 1 comment
Closed

Add class name prefixes to fix potential style leaks #29

rbrtsmith opened this issue May 24, 2017 · 1 comment

Comments

@rbrtsmith
Copy link
Contributor

As it currently stands we are not prefixing our classNames e.g. we have .sidebar
which means consumers CSS is likely to leak into the timeline.

I suggest we prefix all our classNames with rt- to avoid this.

@willbamford willbamford changed the title className prefixes Add class name prefixes to fix potential style leaks May 24, 2017
@willbamford
Copy link
Contributor

We have .react-timelines wrapper which adds some level of protection but agree there is still likely to be some leakage.

Something like .rt or .rtl would help at the expense of readability / noise in the code-base. Would also not guarantee working okay e.g. users can just style p directly and there isn't much we can do about this.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants