Skip to content
This repository has been archived by the owner on May 3, 2021. It is now read-only.

added-display-captions-option #45

Merged
merged 4 commits into from Nov 5, 2020
Merged

added-display-captions-option #45

merged 4 commits into from Nov 5, 2020

Conversation

N-Shar-ma
Copy link
Contributor

Added an option to display instagram post captions as overlay on the posts on hovering. display_caption is true by default. A screenshot of the caption visible on hovering is attached:

image

@jsanahuja jsanahuja self-assigned this Nov 5, 2020
@jsanahuja
Copy link
Owner

Looks great! I made some small changes:

  • Changed display_captions default value to false to avoid changing the current behavior for users that use the CDN.
  • Replaced template string for a normal string (scaping line breaks) as this is not compatible in any version of IE.
  • Added a condition to avoid adding any caption styles if display_captions is disabled.
  • Changed max-width:100% for width:100% to avoid cases like this:
image -> image

Thank you!

@jsanahuja jsanahuja merged commit 4a5f593 into jsanahuja:master Nov 5, 2020
@jsanahuja
Copy link
Owner

Closes #14

@N-Shar-ma
Copy link
Contributor Author

This was my first ever pull request. Thank you for letting me contribute, and for explaining the tweaks you made. I learnt a lot from this experience 😊

@jsanahuja
Copy link
Owner

Noo, thank you for your work! Really appreciated

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants