Skip to content
This repository has been archived by the owner on May 3, 2021. It is now read-only.

jQuery in JS only version docs #39

Closed
Natetronn opened this issue Sep 3, 2020 · 3 comments · Fixed by #40
Closed

jQuery in JS only version docs #39

Natetronn opened this issue Sep 3, 2020 · 3 comments · Fixed by #40

Comments

@Natetronn
Copy link

Natetronn commented Sep 3, 2020

FYI, you have some jQuery in the JS version docs for example 7:

<script type="text/javascript" src="dist/InstagramFeed.min.js"></script>
<script type="text/javascript">
    (function(){
        new InstagramFeed({
            'username': 'instagram',
            'callback': function(data){
                $('#jsonHere').html(JSON.stringify(data, null, 2));
            }
        });
    })();
</script>

However, in your source you're using it correctly:

            new InstagramFeed({
                'username': 'instagram',
                'callback': function(data) {
                    document.getElementById("jsonHere").innerHTML = JSON.stringify(data, null, 2);
                }
            });

Just thought I'd let you know in case you wanted to update accordingly.

@jsanahuja
Copy link
Owner

You are right, I will update it when I have time or if you want feel free to send a pull request :)

@Natetronn
Copy link
Author

I'd be happy to send a PR. I'm not seeing the site in your repos, however.

@jsanahuja
Copy link
Owner

Yes, it is the index.html of this repo

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants