Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(fixTJunctions): fixes issues with fixTJunctions #63

Merged
merged 7 commits into from
Nov 3, 2017

Conversation

kaosat-dev
Copy link
Contributor

@kaosat-dev kaosat-dev commented Nov 1, 2017

This PR is a fix for jscad/scad-api#26

@z3dev
Copy link
Member

z3dev commented Nov 1, 2017

FYI, the CAG goes outside the cube, which may be the reason for the failure.

@kaosat-dev
Copy link
Contributor Author

good catch @z3dev !
it still should not fail this way though, and its a giant mess

@kaosat-dev kaosat-dev changed the title test(fixTJunctions): added test for failing fixTjunction case fix(fixTJunctions): fixes issues with fixTJunctions Nov 3, 2017
@kaosat-dev kaosat-dev merged commit 78c5102 into master Nov 3, 2017
@kaosat-dev kaosat-dev mentioned this pull request Nov 3, 2017
@kaosat-dev kaosat-dev deleted the fix-fixTJunctions branch November 4, 2017 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants