This repository has been archived by the owner on Jul 24, 2022. It is now read-only.
feat(): add ability to deserialize stl to csg #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* adde stubs for output type selection option
* added a first one for ascii stl => jscad * added basics for same to csg & binary to jscad
* metadata injection is now togleable * changed binary vs ascii detection * more internal cleanups
|
openscad.org has some STL files for testing as well. You might want to grab a few of those. |
|
@z3dev I already added stl files to sample-files, no need for a ton, there aren't that many variations in STL |
… stl files * fixed issues with output from binary * restructured internals & cleaned up
* added testing of output csg vertices * added expected file for more comple stl inputs (containing list of csg vertices) * added more tests * moved test to sub folder * updated test commands
|
Hmmm... I don't see a test for STL colors, which I added about 1 year back. Tinkercad produces STL files with colors. See examples/feathers_mcgraw.stl |
|
damn, did not see your comment on time, sorry, will add tests for that later (although my point about not supporting non standard features for stl still stands) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr adds ability to deserialize stl data to CSG objects directly, and adds unit tests