Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Running Tests? (Javascript library) #8

Closed
CodeMan99 opened this issue Jan 18, 2018 · 3 comments
Closed

Running Tests? (Javascript library) #8

CodeMan99 opened this issue Jan 18, 2018 · 3 comments

Comments

@CodeMan99
Copy link
Contributor

REPEAT OF jscrambler/javascript-jscrambler#26 馃憥 Why were no issues handled upon deprecating the previous repository?

--

I'm unsure how the test suite is suppose to function. I'd like to improve the test coverage for a pull request I am preparing, but when I run npm test this is the output I get:

> jscrambler@5.2.1 test /home/code_m/dev/jscrambler/packages/jscrambler-cli
> grunt test 2> /dev/null

>> Local Npm module "grunt-babel" not found. Is it installed?

Running "clean:test" (clean) task
>> 0 paths cleaned.

Running "jasmine_node:test" (jasmine_node) task


Finished in 0.001 seconds
0 tests, 0 assertions, 0 failures, 0 skipped




Running "clean:test" (clean) task
>> 0 paths cleaned.

Done.
@antonio-jscrambler
Copy link
Contributor

Hi,

We are sorry that we didn't handle the issues on the deprecated repo and thank you for creating the issue again.

Regarding the tests for the javascript client, they are aimed to check some use cases like upload, download, get info, protection, etc.

At the moment the npm test command isn't running as intended. We will investigate the issue and address it soon.

We would like to thank you for your effort and help to improve the clients.

@s-coimbra21
Copy link
Contributor

Hi, this probably not what you wanted to hear but those tests are for an old version of our CLI, I have just removed them to prevent any further confusion about it.

That said, feel free to submit any PR you wish, we will review it in due time.

@CodeMan99
Copy link
Contributor Author

Oh man. The changes I want to contribute are large and sweeping changes. Scary to submit code you've never ran.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants