Skip to content
This repository has been archived by the owner on Dec 29, 2020. It is now read-only.

Fail build on unsupported rules #69

Closed
cowwoc opened this issue Dec 8, 2014 · 3 comments
Closed

Fail build on unsupported rules #69

cowwoc opened this issue Dec 8, 2014 · 3 comments

Comments

@cowwoc
Copy link

cowwoc commented Dec 8, 2014

When building using grunt-jscs I get Warning: Unsupported rules: requireSpaceBeforeKeywords Use --force to continue.

Upgrading to a newer version of grunt-jscs fixes the problem but the underlying issue should get fixed. That is: don't silently skip jscs on an unknown rule, break the build instead so developers will notice the problem.

@gustavohenke
Copy link
Member

That's an intended change. See this commit for reference.

@gustavohenke
Copy link
Member

Any further questions, please ask!

@cowwoc
Copy link
Author

cowwoc commented Dec 8, 2014

@gustavohenke I understand that according to jscs-dev/node-jscs#334 this feature is meant to address forward-compatibility, but I (unless I misunderstood what is going on) I don't think it works as intended.

  1. I agree that it's okay to ignore unsupported/unknown flags for forward compatibility.
  2. The part I disagree with is that jscs should totally abort on unknown flags. Instead, I expect it to warn about the unknown flags, and run without them.

Did I misunderstand what is going on? Is JSCS still running (without the unknown flag) when this warning is issued?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants