-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Failed on bootstrap/js/*.js #1
Comments
Working as intended. It's supposed to warn you on code formatting violations, which is what it's doing. |
I cann't understand this. |
Please read the Gulp documentation. You can handle the error if you want. |
I don't need handle error from checker. I want stream, pipe... Checker should not break stream. gulp.task('build:scripts', function() { gulp.src(path.join(app.scripts.src, '**/*.js')) .pipe(jshint()) .pipe(jshint.reporter()) .pipe(jscs()) .pipe(gulp.env.production ? tasks.uglify() : tasks.util.noop()) .pipe(gulp.dest(app.scripts.dst)); }); I read https://github.com/gulpjs/gulp/wiki#articles-and-recipes. |
@6aKa gulp-jshint is planned to start emitting errors as well. You need to handle the error yourself like this gulp.task('build:scripts', function() {
gulp.src(path.join(app.scripts.src, '**/*.js'))
.pipe(jshint())
.pipe(jshint.reporter())
.pipe(jscs().on('error', gutil.log))
.pipe(gulp.env.production ? tasks.uglify() : tasks.util.noop())
.pipe(gulp.dest(app.scripts.dst));
}); Keep in mind that gulp is standard node and doesn't have any magic error handling. Plugins will emit errors, you need to handle them. |
@sindresorhus You should use the new PluginError stuff from gulp-util to lose the stack on these |
@contra Yeah, I'm planning to go through my plugins, but waiting on the streaming changes to be sorted out first. |
@sindresorhus We're leaving everything where it is. Basically all that has changed is that if you are a fundamentally buffered library and you want to support streams you can use @nfroidure's new BufferStream module to make it easy Took quite a clusterfk to get to that decision but I'm confident in it |
Task
Error
Environment
The text was updated successfully, but these errors were encountered: