Skip to content
This repository has been archived by the owner on Mar 23, 2024. It is now read-only.

Add except option for RequireCapitalizedComments #1045

Closed
ashclarke opened this issue Feb 11, 2015 · 8 comments
Closed

Add except option for RequireCapitalizedComments #1045

ashclarke opened this issue Feb 11, 2015 · 8 comments

Comments

@ashclarke
Copy link
Contributor

Hello again!

This is a suggested feature to allow for certain exclusions to this rule, e.g:

"requireCapitalizedComments": {
    "allExcept": ["istanbul", "jshint", "jscs"]
}

istanbul | jshint - see Inline Configuration section | jscs

This allows hint comments to be ignored.

What do you think?

@ashclarke ashclarke changed the title Add exclude option for RequireCapitalizedComments Add except option for RequireCapitalizedComments Feb 11, 2015
@mrjoelkemp
Copy link
Member

Great catch @ashclarke! We should totally do this.

Would you like to give this a go?

@ashclarke
Copy link
Contributor Author

Shall I make jscs and jshint default exceptions?

@AlexanderZeilmann
Copy link
Contributor

I reported this feature in the past #837, but completely forgot about it :-/

I am against making jscs and jshint (or any other values) default exceptions. Why? Because I don't want use inline comments for these two tools and want to get notified, when I do.

@qfox
Copy link
Member

qfox commented Feb 12, 2015

@alawatthe I'd say no. It's a kind of sugar, atm we almost done #109 about presets, and I believe that it could helps a lot with sugar making in common. At other hand, I'm agree with @alawatthe about discouraging defaults.

@AlexanderZeilmann
Copy link
Contributor

@zxqfox I am probably not seeing something obvious, but what has this bug to do with presets?

I'd say no.

"No" to what? I'm a bit confused :-/

@ashclarke
Copy link
Contributor Author

I have created a PR (#1052) with the change. This is one of my first contributions to an established repository, so please offer suggestions and advice if it is A) terrible or B) lacking something important!

@qfox
Copy link
Member

qfox commented Feb 12, 2015

@alawatthe It was a message to @ashclarke, sorry. ;-)

I'm talking about defaults, and presets can help with that.

@AlexanderZeilmann
Copy link
Contributor

@zxqfox Ah, now I get it. No problem :-D

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants