-
-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
out-dated peer dependencies between repository libraries #427
Comments
Semver does not support bumping peer dependencies in the workspace (like Lerna does). It could be a new feature that we can discuss. |
For my use case this is pretty crucial as well! I'm mainly using nx + semver as a build tool for an angular library. If I make at change to a library and then also version and publish it's dependants (through nx affected) it should also update the peerdeps. Otherwise consumers won't know which version of peer deps to install and always get warnings on it. |
@cakeinpanic, thank you for the script; however, don't you think it will be a good idea to have this library do it for you? Updating dependencies is basic. Without it, if LibA requires LibB in a monorepo and the was a change in LibB, both are being published to NPM. Now, if you didn't update "dependencies" in package.json for LibA. a user install and get the old dep. doing it "adhoc" for packages makes it unusable really. |
Hello,
Thanks for the great library. We need an advice.
We have 3 libraries, each has its own version. this is how we setup each library:
Our setup is aligned to the suggestion in readme.md, but we noticed that in NPM packages we have outdated peer dependencies between our libraries.
It happens because this library updates the version of the libraries under
dist
folder during the bumping process but it doesn't update the peer-dependencies versions so it results in outdated versions for peer-dependencies.Although the target
publish
is not part of this library, as it is being executed as postTarget right after this one, we cannot interfere in the middle. We tried but it didn't help because we need first to run the version on all of them and then run targets github and deploy only on those with the changes.Just to note that peer-dependencies are added automatically for inner dependencies during the nx build process
npx nx run-many --target=build --prod --projects=ui-theme,ui-icons,ui-components
I believe others has the same need, so maybe we missed something in the configuration?
Thanks!
The text was updated successfully, but these errors were encountered: