Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version task never returns with nx 17 and version 4.0.0 #743

Closed
bardisg opened this issue Oct 27, 2023 · 4 comments
Closed

Version task never returns with nx 17 and version 4.0.0 #743

bardisg opened this issue Oct 27, 2023 · 4 comments
Labels
bug Something isn't working

Comments

@bardisg
Copy link

bardisg commented Oct 27, 2023

I am using "@jscutlery/semver": "4.0.0" along with "nx": "17.0.2"

My version target is configured in project.json as :

"version": {
      "executor": "@jscutlery/semver:version",
      "options": {
        "baseBranch": "main",
        "preset": "conventional",
        "tagPrefix": "{projectName}@",
        "trackDeps": true,
        "releaseAs": "prerelease",
        "preid": "beta"
      }
    },

When I execute:

nx run version

I can see the logged message for next version calculation "Calculated new version "x.x.x".

Then the process hangs there as if no success or error is ever returned in the runSemver$.pipe https://github.com/jscutlery/semver/blob/main/packages/semver/src/executors/version/index.ts#L205C10-L205C10

Without the "preset": "conventional" seems to work as expected

@bardisg
Copy link
Author

bardisg commented Oct 27, 2023

Seems like the latest version of commitlint 18 bumped its dependency conventional-commits-parser to version 5.

downgrading commitlint to its latest v17 will also change conventional-commits-parser to version 4 and things work again

@edbzn edbzn added the bug Something isn't working label Oct 28, 2023
@StevenCederrand
Copy link

I've recently updated my mono repo to use commitlint:18 which caused all of my releases to hang 😅
There seem to be 30bugs, any idea on how long it would take to have this looked into?

@edbzn
Copy link
Member

edbzn commented Dec 14, 2023

Could you try updating semver to v4.1.0 along with commitlint v18? I believe it's a version conflict with commitlint transitive dependencies. I wrote an e2e test (945c83d) to ensure it's not related to the preset.

@edbzn
Copy link
Member

edbzn commented Dec 14, 2023

I'm going to close, feel free to reopen if still encountered.

@edbzn edbzn closed this as completed Dec 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants