Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue: Inconsistent currency labels #28

Closed
dmitrij-schmidt opened this issue Mar 16, 2018 · 1 comment
Closed

Issue: Inconsistent currency labels #28

dmitrij-schmidt opened this issue Mar 16, 2018 · 1 comment

Comments

@dmitrij-schmidt
Copy link

Description:
Currency labels are inconsistent throughout the project.
In many places they are hardcoded to PHP, for an example in admin/products/show.blade.php they are coded as <td>Php {{ $product->price }}</td>.

On this stage (unless there is a plan to support multiple currencies), currency name should be echoed as in admin/shared/products.blade.php <td>{{ config('cart.currency') }} {{ $product->price }}</td>

Quick search showed 8 results in 6 files:
admin/orders/list.blade.php
admin/orders/show.blade.php
admin/products/create.blade.php
admin/products/show.blade.php
admin/products/edit.blade.php
front/accounts.blade.php

This is quite easy to fix using find/replace in any modern editor (took me like 10 seconds on my local copy). I'm only a beginner when it comes to PHP tests and using github in general, so I'll just post it for now.

@jsdecena
Copy link
Owner

Hi @dmitrij-schmidt Nice catch! Thank you. I have made the correction in the develop branch, see this commit bee94cf

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants