Cannot find oracle jdk from windows registry

[Eskibear]

First I want to thank you for the convenient libary. But I do find below problems:

missing leading slash in key

node-find-java-home/index.js

Line 58 in 6a72df6

"SOFTWARE\\JavaSoft\\Java Development Kit"

I have to add the leading slash to get it work, i.e. \\SOFTWARE....

early return of findInRegistry

It always returns null, without waiting for callback to execute.

node-find-java-home/index.js

Lines 102 to 110 in 6a72df6

	var keysFound =[];
	var keyPath = paths.forEach(function(element) {
	var key = new WinReg({ key: element });
	key.keys(function(err, javaKeys){
	keysFound.concat(javaKeys);
	});
	}, this)
	if(!keysFound.length) return null;

new registry key for JDK 11/12

For Oracle JDK 11/12, it uses a new key SOFTWARE\\JavaSoft\\JDK.

Can you kindly fix these?

[Eskibear]

Can you kindly fix these?

My work is currently blocked by this issue, and I tried to fix it by myself but the JS callback hell just... Is there any possibility to get the issue fixed recently? I don't want to re-invent the wheel if someone can fix it.
Thanks in advance.

[jsdevel]

I'm sorry, but this is an open source project that I am not getting paid to support. I am happy to review pull requests and merge code and publish this module, but you will have to fix this on your own to help the community.

[Eskibear]

I would have sent out the PR if I was able to create it.
JS with callback hell is too hard to maintain (at least for me), and now there's more elegant way to handle async functions in JS world. If you do want me to fix the issue, I have to rewrite the whole project in TS. Are you willing to accept that kind of PR?

[jsdevel]

@Eskibear i'm totally cool with refactoring the project to TS! If possible though, can you do that first before fixing your issue? that way it's easier to track what exactly changed.

this was written when node v0.10 was the stable version...