Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Have to escape double quotes #9

Closed
KyleAMathews opened this issue Jun 5, 2014 · 4 comments
Closed

Have to escape double quotes #9

KyleAMathews opened this issue Jun 5, 2014 · 4 comments

Comments

@KyleAMathews
Copy link
Contributor

I included double-quotes inside an <h2> and things didn't work until I escaped them e.g. <h2>Streaming tweets matching \"{@state.following}\"</h2>

This is the error that browserify spit out:

following = React.DOM.h2(null, "Streaming tweets matching "", (@state.following), """)
                                                                 ^^^^^^^^^^^^^^^^^^^^^^^^
ParseError: unexpected ", (@state.following), "
@jsdf
Copy link
Owner

jsdf commented Jun 6, 2014

Ahh yes, I had started down the road of string-escaping CJSX text nodes, but forgot to finish implementing it. I'll get onto it.

@jsdf
Copy link
Owner

jsdf commented Jun 6, 2014

Fixed in 5a5b038

@KyleAMathews
Copy link
Contributor Author

Thanks! Confirmed the fix so closing this. And thanks for the great module! I've been looking at React for a while and was really hoping for something like this to crop up.

@jsdf
Copy link
Owner

jsdf commented Jun 7, 2014

published to npm in version 0.3.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants