Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependencies are out of date #28

Closed
jez opened this issue Aug 7, 2015 · 4 comments
Closed

Dependencies are out of date #28

jez opened this issue Aug 7, 2015 · 4 comments

Comments

@jez
Copy link

jez commented Aug 7, 2015

Looks like Facebook deprecated JSTransform and react-tools in June. It's being replaced by Babel, which is probably for the better.

https://facebook.github.io/react/blog/2015/06/12/deprecating-jstransform-and-react-tools.html

@jsdf
Copy link
Owner

jsdf commented Nov 14, 2015

I'm not sure pulling babel in as a dependency is ideal, because all that we're using from react-tools is the displayname transform :\

@jez
Copy link
Author

jez commented Dec 31, 2015

I was just doing some spring winter break cleaning of issue's I'm following and I noticed that recently you removed jstransform with coffee-react-transform. I looked at it on npm, but it didn't have any documentation.

Was that done to address this issue? (It's hard to tell without knowing what coffee-react-jstransform is!)

@jsdf
Copy link
Owner

jsdf commented Dec 31, 2015

Not much. It's still using jstransform, I've just vendored it into the new package. Literally all it is used for is one tiny syntax transform on the JS output of the Coffeescript compiler (to add in the displayName property). The output of the CS compiler hopefully a fairly stable target, as it aims to keep support for some fairly legacy browsers. Until there are actual demonstrable problems with using jstransform I'd rather do that than pull in Babel for this one very small thing.

@fa7ad
Copy link

fa7ad commented Jan 14, 2016

may be it will add better error handling? #32

@jsdf jsdf closed this as completed Apr 17, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants