Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ladda's CSS must be made part of react-ladda package #51

Open
InamTaj opened this issue Aug 24, 2017 · 4 comments
Open

Ladda's CSS must be made part of react-ladda package #51

InamTaj opened this issue Aug 24, 2017 · 4 comments

Comments

@InamTaj
Copy link

InamTaj commented Aug 24, 2017

As this package is intended for react-apps, the css file for ladda buttons must be included in the react-ladda package so that one can perform clean imports / builds in projects that use webpack + css-modules for managing CSS.

Example Usage from my app's App.js:

...
// imports of CSS styles of 3rd-party packages
import 'font-awesome/css/font-awesome.min.css';
import 'rc-slider/assets/index.css';
import 'react-datepicker/dist/react-datepicker.css';
import 'react-select/dist/react-select.css';
@austinbutler
Copy link

I think you can still import the CSS from Ladda itself from its dist folder, since it gets installed with react-ladda.

@InamTaj
Copy link
Author

InamTaj commented Aug 7, 2018

@austinbutler I've already checked and there is no style available in the dist folder.

@austinbutler
Copy link

I am referring to the ladda module itself, not react-ladda.

image

@InamTaj
Copy link
Author

InamTaj commented Aug 9, 2018

@austinbutler Yes this is what I did eventually. But the issue I opened is that the style should be included in the react-ladda so that it's easier to use.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants