Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overriding default helpers does not always work #15

Closed
vdininski opened this issue Feb 13, 2015 · 3 comments
Closed

Overriding default helpers does not always work #15

vdininski opened this issue Feb 13, 2015 · 3 comments

Comments

@vdininski
Copy link

Not sure, but I think there might be a race condition when loading helpers (default and custom/overrides). My exact use case is the following:

  • create a custom helper override (e.g. linkify)
  • run the jsdoc-to-markdown with the necessary parameters

Occasionally the default helpers is used instead of the override. Not sure whether I should post this here or in jsdoc-to-markdown, but seeing that it concerns a dmd helper I decide this would be a better place.

@vdininski vdininski changed the title Overriding default helpers not always works Overriding default helpers does not always work Feb 13, 2015
@75lb
Copy link
Member

75lb commented Feb 13, 2015

i need to try and reproduce this, do you have some code i can check out and run?

@vdininski
Copy link
Author

What I am doing is simply creating and loading a helper named linkify and using it in a custom template. Then I am expecting to see the value processed by my helper. However occasionally the value from the original helper is displayed.

@75lb
Copy link
Member

75lb commented Mar 1, 2015

i just upgraded the way overriding helpers works.. i have been testing and i can't reproduce this with the latest code..

i added this linker override (notice the helper file structure has changed, now it's just a standard module). If you pull the latest code and run this in your dmd fork, you should see the output from the overridden helper:

$ cat test/fixture/file-set.json | dmd --helper test/overrides/helpers.js

i ran it many times, and with different input file, and failed to see the race condition.. how about you? what's the status with this issue?

@75lb 75lb closed this as completed Apr 7, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants