Skip to content

Commit

Permalink
fix displaying of falsy default values in haruki template
Browse files Browse the repository at this point in the history
  • Loading branch information
rainum committed Sep 10, 2015
1 parent a6927b2 commit 4f9545c
Showing 1 changed file with 5 additions and 3 deletions.
8 changes: 5 additions & 3 deletions templates/haruki/publish.js
Expand Up @@ -7,6 +7,8 @@
*/
'use strict';

var hasOwnProp = Object.prototype.hasOwnProperty;

function graft(parentNode, childNodes, parentLongname, parentName) {
childNodes
.filter(function (element) {
Expand Down Expand Up @@ -83,7 +85,7 @@ function graft(parentNode, childNodes, parentLongname, parentName) {
'name': element.params[i].name,
'type': element.params[i].type? (element.params[i].type.names.length === 1? element.params[i].type.names[0] : element.params[i].type.names) : '',
'description': element.params[i].description || '',
'default': element.params[i].defaultvalue || '',
'default': hasOwnProp.call(element.params[i], 'defaultvalue') ? element.params[i].defaultvalue : '',
'optional': typeof element.params[i].optional === 'boolean'? element.params[i].optional : '',
'nullable': typeof element.params[i].nullable === 'boolean'? element.params[i].nullable : ''
});
Expand Down Expand Up @@ -138,7 +140,7 @@ function graft(parentNode, childNodes, parentLongname, parentName) {
'name': element.params[i].name,
'type': element.params[i].type? (element.params[i].type.names.length === 1? element.params[i].type.names[0] : element.params[i].type.names) : '',
'description': element.params[i].description || '',
'default': element.params[i].defaultvalue || '',
'default': hasOwnProp.call(element.params[i], 'defaultvalue') ? element.params[i].defaultvalue : '',
'optional': typeof element.params[i].optional === 'boolean'? element.params[i].optional : '',
'nullable': typeof element.params[i].nullable === 'boolean'? element.params[i].nullable : ''
});
Expand Down Expand Up @@ -180,7 +182,7 @@ function graft(parentNode, childNodes, parentLongname, parentName) {
'name': element.params[i].name,
'type': element.params[i].type? (element.params[i].type.names.length === 1? element.params[i].type.names[0] : element.params[i].type.names) : '',
'description': element.params[i].description || '',
'default': element.params[i].defaultvalue || '',
'default': hasOwnProp.call(element.params[i], 'defaultvalue') ? element.params[i].defaultvalue : '',
'optional': typeof element.params[i].optional === 'boolean'? element.params[i].optional : '',
'nullable': typeof element.params[i].nullable === 'boolean'? element.params[i].nullable : ''
});
Expand Down

0 comments on commit 4f9545c

Please sign in to comment.