Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modifying dropdownMenu wrap element #68

Closed
handonam opened this issue Nov 9, 2015 · 1 comment
Closed

Modifying dropdownMenu wrap element #68

handonam opened this issue Nov 9, 2015 · 1 comment

Comments

@handonam
Copy link

handonam commented Nov 9, 2015

There's a line on 153 for directive dropdownMenu that has this:

var $wrap = $compile(angular.element(
  '<div class="wrap-dd-menu" ng-class="{\'disabled\': dropdownDisabled}"></div>')
)($scope);

it seems a bit too rigid, and we can't modify it. dropdownSelect seems to have this built into the templateCache. Shouldn't the menu's wrap be moved out to templateCache as well?

@jseppi
Copy link
Owner

jseppi commented Nov 9, 2015

Great idea! If you can do a PR I'll review and merge it in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants