Skip to content
This repository has been archived by the owner on Oct 1, 2022. It is now read-only.

F-Droid inclusion #627

Open
Hiradur opened this issue Jul 2, 2017 · 9 comments
Open

F-Droid inclusion #627

Hiradur opened this issue Jul 2, 2017 · 9 comments

Comments

@Hiradur
Copy link

Hiradur commented Jul 2, 2017

From the F-Droid webpage [1]:
F-Droid is an installable catalogue of FOSS (Free and Open Source Software) applications for the Android platform. The client makes it easy to browse, install, and keep track of updates on your device.

It would be great to have JSettlers on F-Droid as well. One of the inclusion criteria [2] appears to be that the authors of the software know of the inclusion and support it. So I hereby ask you if you would support such an inclusion.

I already wrote a draft for a package request which would be posted on their package request tracker [3].

Draft:

* [ ] The app complies with the [inclusion citeria](https://f-droid.org/wiki/page/Inclusion_Policy)
* [x] The app is not already listed in the repo or issue tracker.
* [ ] The original app author has been notified (and supports the inclusion).

---------------------

### Link to the source code:

https://github.com/jsettlers/settlers-remake

### Link to app in another app store:

N/A

### License used:

MIT

### Category:

Games

### Summary:

Reimplementation of the The Settlers III game engine

### Description:

JSettlers is a free and open source reimplementation of the The Settlers III game engine.

Features:
- fully working economy but only Romans are playable at the moment
- AI opponents
- cross-platform network play

Antifeatures: 
- Non-Free Assets: The "GFX" and "SND" folders of the original game are required in order to play the game. They can be taken from the full game or the The Settlers III Amazons Demo which can be downloaded at no cost on the internet.

### Project Website: 

https://www.settlers-android-clone.com

### Android specific documentation:

https://www.settlers-android-clone.com/android-user-guide/

### Issue tracker:

https://github.com/jsettlers/settlers-remake/issues

Before I get the OK from you and submit the package request please read over the inclusion criteria [2] as well as the draft and tell me if there are any issues.

[1] https://f-droid.org
[2] https://f-droid.org/wiki/page/Inclusion_Policy
[3] https://gitlab.com/fdroid/rfp/issues

@andreas-eberle
Copy link
Member

First of all, thanks for bringing this up!

I briefly read through the policies of f-droid and was wondering if we can even apply for it. The thing is that we don't own the graphics and cannot deliver them with the app. The user has to manually copy them on the device (this way we don't do something with the graphics files we don't own...). Would it even be possible to be included in f-droid under this circumstances?

@Hiradur
Copy link
Author

Hiradur commented Jul 10, 2017

I was wondering about this as well. I think the best way to find out would be to create a package request so the people in charge can take a look at it.

@Hiradur
Copy link
Author

Hiradur commented Jul 22, 2017

I opened a ticket here: https://gitlab.com/fdroid/rfp/issues/264

Let's see what they say.

@gollum1001
Copy link
Contributor

Would it be legal (in Germany) to download and extract it automatically ?

@Hiradur
Copy link
Author

Hiradur commented Apr 19, 2018

I decided to try to create the necessary metadata for the F-Droid build server myself. I set up the F-Droid build environment and ran the build for the 0.4 release but I get this error:

ERROR: Found unknown maven repo 'https://raw.github.com/laenger/maven-releases/master/releases' at build.gradle

Having no experience with building for Android I'm unsure if it's a problem with JSettlers itself or F-Droid. If I go to that link in a webbrowser I only get 404: Not Found. Any ideas?

@andreas-eberle
Copy link
Member

@tom-pratt: Do you have an idea?

@tom-pratt
Copy link
Member

Yeah it's this library used in the in game menus. Maybe his link is just temporarily down. He should just put it on jcenter!

https://github.com/laenger/ViewPagerBottomSheet

@nicolasmaia
Copy link

Is it still using this repository? F-Droid considers it untrusted, which is why it can't build

@IzzySoft
Copy link

Issue is still pending on our end because of that. Any chance you could e.g. include the source of that using a git submodule? Meanwhile, I'll copy your comment regarding the graphics over to our issue, @andreas-eberle – let's see what our specialists say.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants