Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request package vulnerable to SSRF #1312

Closed
nicolasraffray opened this issue Mar 17, 2023 · 2 comments
Closed

Request package vulnerable to SSRF #1312

nicolasraffray opened this issue Mar 17, 2023 · 2 comments

Comments

@nicolasraffray
Copy link

Snyk has identified an issue with the request module being used by jsforce.

https://security.snyk.io/vuln/SNYK-JS-REQUEST-3361831


Overview
request is a simplified http request client. Affected versions of this package are vulnerable to Server-side Request Forgery (SSRF) due to insufficient checks in the lib/redirect.js file by allowing insecure redirects in the default configuration, via an attacker-controller server that does a cross-protocol redirect (HTTP to HTTPS, or HTTPS to HTTP).

NOTE: This package has been deprecated, so a fix is not expected. See request/request#3142.

I understand the switch away from using request is queued up for V2 but given this vulnerability can it be moved forward?

@tapasthakkar
Copy link

tapasthakkar commented May 17, 2023

We can move to postman-request it's a fork of the original request package and being actively maintained

@cristiand391
Copy link
Member

closing this as dup of #999

@cristiand391 cristiand391 closed this as not planned Won't fix, can't repro, duplicate, stale Oct 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants