Skip to content
This repository has been archived by the owner on Oct 28, 2019. It is now read-only.

Adding custom amount of money is completely broken #1576

Closed
Leopard1907 opened this issue Apr 17, 2018 · 13 comments
Closed

Adding custom amount of money is completely broken #1576

Leopard1907 opened this issue Apr 17, 2018 · 13 comments

Comments

@Leopard1907
Copy link

I'm trying it with both Firefox and Chrome , no matter what amount i type in there it proceeds to add 10 TL (Turkish Lira) to my account.

Firefox , Chrome and ES are both on the latest versions.

@ghost
Copy link

ghost commented Apr 23, 2018

Adding of custom amount (for both Gift Wallet and Personal top-up) does not work for dev 9.9 too. Any help/update on that? Posted in Steam Discussion & Reddit but no reply. Urgently need help on this. :)

@jshackles
Copy link
Owner

The latest fix I made to the 9.9 dev branch (in commit d1a11b9) is still working correctly for me in Chrome. I just used it to add $7.12 to my Steam wallet.

If the fix isn't working for you, can you let me know if you are getting any error messages in the browser console (F12)?

@ghost
Copy link

ghost commented Apr 23, 2018

Sorry I am not so technical at this. but what I got was this:

2018-04-23_124312

I tried manually changing the data-amount and didn't work too. And yes, I'm sure I'm using 9.9.

2018-04-23_124354

@jshackles
Copy link
Owner

@BryanChung Thanks for the update, it looks like this has to do with how your country's currency is formatted. I'll try running the add_custom_money_amount() function through the parse_currency() function prior to assigning the value which should clear that error and allow the function to work correctly.

Curious - did it work for you before Valve made their most recent changes? It doesn't seem like it should have.

@ghost
Copy link

ghost commented Apr 23, 2018

Thanks for looking into it and fast!

Erm, I didn't try it until 4 days ago then realised I cannot add custom amount. I was trying to purchase custom amount for a friend, then realised both gift wallet and personal purchase doesn't work.

Will the gift custom amount for friend works too?

@jshackles
Copy link
Owner

Once this function gets fixed up properly, it should work for both pages.

@ghost
Copy link

ghost commented Apr 23, 2018

Great! You're working on a fix now? It will be in dev or stable channel?

@jshackles
Copy link
Owner

The fix will probably be ready some time in the next 24 hours, and it will roll out to the dev branch first. Stay tuned.

@ghost
Copy link

ghost commented Apr 23, 2018

Ok! Will be a new version number I supposed?

@ghost
Copy link

ghost commented Apr 23, 2018

Doesn't seem to work. :(

I got that error when I click purchase after custom input of SGD $4.00. Trying to buy that wallet amount for a friend.

2018-04-24_001503

Here's the previous screen.

2018-04-24_001631

@jshackles
Copy link
Owner

It appears that S$6 is the minimum purchase amount in your region, so any amount less than that would result in the transaction error you're seeing.

@ghost
Copy link

ghost commented Apr 23, 2018

Ah damn. No wonder. It was previously working even less than $4 though. Crap Steam.

@Leopard1907
Copy link
Author

Leopard1907 commented May 7, 2018

@jshackles 9.9 dev branch fixed this issue for me. Thanks.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants