You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
With just a couple of tweaks, the tabview is working fine with Bootstrap 3.0.2.
The name of the Y.Bootstrap.Tabview object referenced in documentation is actually T.Bootstrap.TabView, note the upper case V, and the constructor puts an extra "nav-tabs" class on the tabview container which causes the styling to be applied twice (once to the container, once to the actual tabs). The latter can be fixed by by removing the class immediately after creating the tabview.
But that raises the issue of overall compatibility and updates for the Bootstrap modules. They haven't been updated in a while, and Bootstrap has moved on. I suspect there will be other tweaks required. Are you planning on testing and updating this for BS 3? Should it be forked to perhaps Y.Bootstrap3?
Thanks,
Erik.
The text was updated successfully, but these errors were encountered:
Okay, I see from previous comments that you are not all that jazzed about maintaining this. I guess I'll fork it or just copy it and modify as I need to.
In any case, thanks for the great work on this. It saves me, at least temporarily, from jquery plugin hell.
Although the docs state and demonstrate that changes must be made to tab markup, I actually found that the only change required is to wrap the tab nav + tab page within a container div, said new div becoming the node for the navview. In other words, the shifting of data-toggle from the tab items to the ul and the container div is not necessary.
Hi John,
With just a couple of tweaks, the tabview is working fine with Bootstrap 3.0.2.
The name of the Y.Bootstrap.Tabview object referenced in documentation is actually T.Bootstrap.TabView, note the upper case V, and the constructor puts an extra "nav-tabs" class on the tabview container which causes the styling to be applied twice (once to the container, once to the actual tabs). The latter can be fixed by by removing the class immediately after creating the tabview.
But that raises the issue of overall compatibility and updates for the Bootstrap modules. They haven't been updated in a while, and Bootstrap has moved on. I suspect there will be other tweaks required. Are you planning on testing and updating this for BS 3? Should it be forked to perhaps Y.Bootstrap3?
Thanks,
Erik.
The text was updated successfully, but these errors were encountered: