Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tabview / BS 3 compatability #4

Open
adapterik opened this issue Nov 7, 2013 · 2 comments
Open

Tabview / BS 3 compatability #4

adapterik opened this issue Nov 7, 2013 · 2 comments

Comments

@adapterik
Copy link

Hi John,

With just a couple of tweaks, the tabview is working fine with Bootstrap 3.0.2.
The name of the Y.Bootstrap.Tabview object referenced in documentation is actually T.Bootstrap.TabView, note the upper case V, and the constructor puts an extra "nav-tabs" class on the tabview container which causes the styling to be applied twice (once to the container, once to the actual tabs). The latter can be fixed by by removing the class immediately after creating the tabview.

But that raises the issue of overall compatibility and updates for the Bootstrap modules. They haven't been updated in a while, and Bootstrap has moved on. I suspect there will be other tweaks required. Are you planning on testing and updating this for BS 3? Should it be forked to perhaps Y.Bootstrap3?

Thanks,
Erik.

@adapterik
Copy link
Author

Okay, I see from previous comments that you are not all that jazzed about maintaining this. I guess I'll fork it or just copy it and modify as I need to.
In any case, thanks for the great work on this. It saves me, at least temporarily, from jquery plugin hell.

@adapterik
Copy link
Author

Although the docs state and demonstrate that changes must be made to tab markup, I actually found that the only change required is to wrap the tab nav + tab page within a container div, said new div becoming the node for the navview. In other words, the shifting of data-toggle from the tab items to the ul and the container div is not necessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant