Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOMContentLoaded and asset loaders #10

Open
rolandtoth opened this issue Jan 17, 2017 · 4 comments
Open

DOMContentLoaded and asset loaders #10

rolandtoth opened this issue Jan 17, 2017 · 4 comments

Comments

@rolandtoth
Copy link

Hi,

thank you for this nice "plugin" - finally I found the one that works without jQuery (and works just as good).

I have my own asset loader and it dynamically loads JS and CSS. The problem is that DOMContentLoaded fires before Animate steps in so the setting "onLoad" is not working. Items are loading on scroll but items which are in viewport by default are not.

Is there a way to fix this? I modified animate.js to render() on window.load instead document.DOMContentLoaded so it is working fine now. Perhaps adding a new setting "onWindowLoad"?

@jshjohnson
Copy link
Owner

Hey - I would happily review a PR for this :)

@rolandtoth
Copy link
Author

I will keep this in memory, not sure when will I have time to check.

@jshjohnson
Copy link
Owner

Apologies for the late reply!

@orditeck
Copy link

orditeck commented Jul 8, 2019

Would be really great if the simple fix could be merged & release on npm :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants