Fixes issue where deepmerge concatenates arrays inside DEFAULT_CONFIG #496
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... instead of replacing them.
Description
provides
deepmerge
with a function to replace its typical array merging behavior with a function that overwrites the destination array with a copy of the source array instead of concatenating the two.Documentation for that feature here: https://www.npmjs.com/package/deepmerge#arraymerge
Motivation and Context
Without this fix, the
searchFields
config will always have[ 'label', 'value']
plus whatever config the user passes in, making it impossible to NOT search bothlabel
andvalue
#495
How Has This Been Tested?
Tests included in PR. Basically, attempt to type
value
entries into the search input, and make sure there are no results.Types of changes
Checklist: