Update choices.scss. Fixed a bug with the height of the source element. #749
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed a bug with the height of the source element. Added property "box-sizing: border-box;"
8 tasks
jshjohnson
reviewed
Nov 10, 2019
| @@ -152,6 +152,7 @@ $choices-icon-cross-inverse: url(data:image/svg+xml;base64,PHN2ZyB3aWR0aD0iMjEiI | |||
| font-size: $choices-font-size-md; | |||
| min-height: 44px; | |||
| overflow: hidden; | |||
| box-sizing: border-box; | |||
There was a problem hiding this comment.
Instead of applying this to specific selectors, could we not just apply to everything within the .choices class?
Something like:
.choices *, .choices *:before, .choices *:after { {
box-sizing: border-box;
}There was a problem hiding this comment.
Yes, we can apply to everything selectors, but we will lose a little performance.
I noticed that this is necessary for two classes.
There was a problem hiding this comment.
Universal selectors are slow and box-sizing is inheriting to children, so, agree with @dios-oleg that those styles better be applied when needed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixed a bug with the height of the source element. Added property "box-sizing: border-box;"
Screenshots (if appropriate)
Before: https://yadi.sk/i/tsTioPhHB3QNgg
After: https://yadi.sk/i/R1jkMhqK_jDKLQ
Types of changes
Fixed CSS.
Checklist